Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull fix for issue #42 #48

Closed
wants to merge 6 commits into from
Closed

Conversation

tomlanyon
Copy link

Are you happy with this fix for #42, essentially copying the TCP data to another buffer.

I considered actually changing tcp.data to be a new buffer for each packet but wasn't sure it was worth it.

tomlanyon and others added 6 commits May 2, 2012 16:05
There are two types of tcp options:
  - "A single octet of option-kind"
  - "An octet of option-kind, an octet of option-length, and
     the actual option-data octets."

Only option 0 and 1 are single the single octet type. So we safely
determine the length of unknown options and skip them.
It can arrive when state machine is in any state, previous version failed for some dumps.
Merged from github/throughnothing d2f4fe4

Conflicts:

	pcap.js
@ujjwalt
Copy link
Collaborator

ujjwalt commented Nov 17, 2013

@tomlanyon Can you look into this if it's already fixed or not?

@jmaxxz
Copy link
Collaborator

jmaxxz commented Mar 12, 2015

Cleaning up pull requests

Reopen with one based on current master if this is still an issue.

@jmaxxz jmaxxz closed this Mar 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants