Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

using node 0.3.0, tests fail right, left and center #40

Closed
jwatte opened this Issue · 3 comments

2 participants

Jon Watte Matt Ranney
Jon Watte

The parsing of the response seems to have totally broken in node 0.3.0 -- I just get raw buffer objects back.
I'm using node 0.3.0, redis 2.0.4 and node_redis 0.3.8.
Btw: I tried this out, because redis-client also had the same problem, just shuffing buffers back.

Matt Ranney
Owner

node_redis has always returned buffer objects, even though it seems that most people don't put binary data into Redis.

The next major release of node_redis will probably have an option to return strings if you like. It should be faster that way as well.

I can't reproduce any test failures with node 0.3.0 or any other versions of node. I run the tests like this:

rv-mjr2:~/work/node_redis (master)$ node test.js 
- flushdb: 1 ms
- multi_1: 1 ms
- multi_2: 0 ms
- multi_3: 1 ms
- multi_4: 0 ms
- multi_5: 0 ms
- multi_6: 1 ms
- watch_multi:Skipping WATCH_MULTI because server version isn't new enough.
 0 ms
- hset: 1 ms
- hmget: 0 ms
- hincrby: 1 ms
- subscribe: 1 ms
- subscribe_quit: 0 ms
- exists: 1 ms
- del: 0 ms
- type: 1 ms
- keys: 0 ms
- multibulk_zero_length: 0 ms
- randomkey: 1 ms
- rename: 0 ms
- renamenx: 1 ms
- dbsize: 0 ms
- get: 0 ms
- set: 0 ms
- getset: 1 ms
- mget: 0 ms
- setnx: 1 ms
- setex: 0 ms
- msetnx: 0 ms
- hgetall: 1 ms
- hgetall_null: 0 ms
- utf8: 3 ms
- sadd: 1 ms
- sismember: 0 ms
- scard: 0 ms
- srem: 1 ms
- spop: 0 ms
- sdiff: 2 ms
- sdiffstore: 1 ms
- smembers: 0 ms
- smove: 1 ms
- sinter: 1 ms
- sinterstore: 1 ms
- sunion: 0 ms
- sunionstore: 0 ms
- sort: 2 ms
- blpop: 0 ms
- blpop_timeout: 1786 ms
- expire: 2001 ms
- ttl: 501 ms

  completed 50 tests in 4318 ms
Matt Ranney
Owner

Can you give me more information on the failing tests? Nobody else has reported this, but I'd like to make sure that there isn't a code issue here.

Matt Ranney
Owner

The latest version of node_redis returns JavaScript String objects by default.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.