Matt Ranney mranney

mranney commented on pull request uber/tchannel#763
@mranney

Yes, this is a node-ism. The convention for callbacks it to be (err, res), where the first arg is an Error object or null. This is how node handles…

mranney commented on issue tsenart/vegeta#126
@mranney

Yeah, I get that. The constant load design is why I started using it. :) What I've found though is that it becomes risky to use in some environment…

mranney commented on pull request uber/tchannel#698
@mranney

I think this is a useful thing to add. I was just hoping there'd be a clean way to specify who should use it and when.

@mranney
Feature: detect overload
mranney commented on pull request uber/tchannel#698
@mranney

Who would send back such errors, only routers?

mranney deleted branch timeouts at uber/tchannel
mranney deleted branch mjr-readme at uber/tchannel
mranney deleted branch contribution-guidelines at uber/tchannel
mranney commented on commit uber/node_redis@2e2b03769d
@mranney

Is this something that should be upstreamed?

mranney commented on issue uber/tchannel#534
@mranney

Since it is already open source, you can break this into another repo without going through the process. In the future, we are going to group these…

mranney commented on issue uber/tchannel#502
@mranney

Yeah, I like adding ttl to claim/cancel.

mranney commented on pull request uber/tchannel#513
@mranney

I'm glad to see that we've moved to an all-emoji based code review system. 🎃

mranney commented on issue uber/tchannel#486
@mranney

I like all of the limits that @jcorbin proposed. 128 headers, arg1 max 16KB, 16 bytes header key length.

mranney commented on pull request Voxer/lb_pool#9
@mranney

LGTM

mranney commented on pull request uber/tchannel#457
@mranney

This looks great to me. I think we should consider adding a fully open state as @leizha suggested, but we can do this in the future.

mranney commented on pull request uber/tchannel#444
@mranney

I like advertise going into the protocol, but I'm worried about breaking existing implementations. Is there some way to do this with v2, or does it…

mranney commented on pull request uber/tchannel#412
@mranney

I like that sometimes we know for sure that the "unexpected" error is a network error, but in a world with 0x07, when would we ever use 0x05?

mranney commented on pull request Voxer/lb_pool#8
@mranney

LGTM, but is there any way to add a test for this? @anandsuresh can you please review?

mranney commented on issue mranney/node_pcap#165
@mranney

We use some larger buffers by default, which might not be appropriate on your more modest hardware. Try lowering them and see if that helps.

@mranney
mranney merged pull request uber/tchannel#196
@mranney
Clariy semantics of call res fields
1 commit with 2 additions and 2 deletions
mranney commented on pull request uber/airlock#8
@mranney

Great work. Now to accomplish a 16,000x speedup in the rest of our code.

mranney commented on pull request uber/airlock#8
@mranney

For those following along at home, I've proposed a similar algorithm, which @markyen is going to try. I like 7000x, but I like 14000x even more.

mranney commented on pull request uber/tchannel#167
@mranney

Seems fine to me.

mranney deleted branch go-readme-typo at uber/tchannel
@mranney
mranney merged pull request uber/tchannel#159
@mranney
Update README.md
1 commit with 1 addition and 1 deletion
mranney deleted branch mjr-client-only-spec at uber/tchannel
@mranney
  • @mranney 7b20e0b
    Merge pull request #152 from uber/mjr-client-only-spec
  • @mranney 6defa84
    Add parens in case you forgot what section of the Unix manual to use.
  • 1 more commit »