For systems that don't have libgpgme installed, the addition of the m4/gpgme.m4 file fixes the following error when running the autogen.sh script: configure.ac:313: error: possibly undefined macro: AC_DEFINE If this token and others are legitimate, please use m4_pattern_allow. See the Autoconf documentation. configure.ac:326: error: possibly undefined macro: AM_PATH_GPGME configure.ac:329: error: possibly undefined macro: AC_MSG_FAILURE
Within the access loop always call fko_destroy() right up front whenever ctx != NULL to ensure a clean slate each time through the loop regardless of what state may have been reached the previous time through the loop.
…ed msg pointer in fko_new_with_data()
…to use ctx->message_type in fko_set_spa_client_timeout()
…a high-order bits' bug found by Coverity
… be executed
…ssue (discovered by Coverity)
From the config file comments: This variable controls whether fwknopd is permitted to sniff SPA packets regardless of whether they are received on the sniffing interface or sent from the sniffing interface. In the later case, this can be useful to have fwknopd sniff SPA packets that are forwarded through a system and destined for a different network. If the sniffing interface is the egress interface for such packets, then this variable will need to be set to "Y" in order for fwknopd to see them. The default is "N" so that fwknopd only looks for SPA packets that are received on the sniffin PCAP_ANY_DIRECTION N;
…mmand line argument.