Skip to content
Commits on Nov 13, 2013
  1. [server] ignore pcap direction for sniffing link type DLT_NULL interf…

    …aces (fixes OS X 10.9 test suite runs)
    committed Nov 12, 2013
  2. [libfko] Candidate build fix for Mac OS X 10.9 (closes #108)

    Nikolay Kolev reported a build issue on Mac OS X 10.9 (Mavericks) where fwknop
    copies of strlcpy() and strlcat() functions were conflicting with those that ship
    with OS X 10.9.
    The solution was to add a check for strlcat() and strlcpy() and
    wrap "#if !HAVE_..." checks around those functions.
    A portion of the build errors looked like this:
    /Applications/  all-recursive
    Making all in lib
    /bin/sh ../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I..   -I ../common   -g -O2 -Wall -Wformat -Wformat-security -fstack-protector-all -fstack-protector -fPIE -D_FORTIFY_SOURCE=2 -MT base64.lo -MD -MP -MF .deps/base64.Tpo -c -o base64.lo base64.c
    libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I.. -I ../common -g -O2 -Wall -Wformat -Wformat-security -fstack-protector-all -fstack-protector -D_FORTIFY_SOURCE=2 -MT base64.lo -MD -MP -MF .deps/base64.Tpo -c base64.c  -fno-common -DPIC -o .libs/base64.o
    In file included from base64.c:34:
    In file included from ./fko_common.h:149:
    ./fko_util.h:56:9: error: expected parameter declarator
    size_t  strlcat(char *dst, const char *src, size_t siz);
    /usr/include/secure/_string.h:111:44: note: expanded from macro 'strlcat'
      __builtin___strlcat_chk (dest, src, len, __darwin_obsz (dest))
    /usr/include/secure/_common.h:39:62: note: expanded from macro '__darwin_obsz'
     #define __darwin_obsz(object) __builtin_object_size (object, _USE_FORTIFY_LEVEL > 1 ? 1 : 0)
    committed Nov 12, 2013
Commits on Oct 31, 2013
  1. [perl FKO module] added a series of encryption + HMAC key tests with …

    …single bytes converted to NULL
    committed Oct 30, 2013
Commits on Oct 28, 2013
Commits on Oct 27, 2013
Commits on Oct 26, 2013
  1. [test suite] added valgrind output interpretation for Test::Valgrind …

    …output for previous run comparisons
    committed Oct 25, 2013
Commits on Oct 25, 2013
Commits on Oct 23, 2013
  1. Revert "[test suite] minor Test::Valgrind name typo fix"

    This reverts commit 6420240.
    committed Oct 22, 2013
Commits on Oct 22, 2013
  1. [test suite, FKO module] new(), spa_data_final(), and other fcns don'…

    …t require key length args
    committed Oct 21, 2013
  2. [test suite] Add support for Test::Valgrind against the perl FKO module

    When --enable-valgrind is used, this commit adds support for running the
    perl FKO built-in tests (in the t/ directory) under the CPAN
    Test::Valgrind module.  A check is performed to see whether
    Test::Valgrind is install before attempting to use it.  Any 'fko_'
    function that shows up under the test output is flagged and causes the
    test-suite test to fail.
    committed Oct 21, 2013
Commits on Oct 11, 2013
Commits on Sep 15, 2013
  1. @damienstuart

    Fixed missing error codes and error tests.

    damienstuart committed with Damien Stuart Sep 15, 2013
Commits on Sep 7, 2013
  1. @damienstuart
Commits on Sep 6, 2013
  1. minor ChangeLog typo update

    committed Sep 5, 2013
Commits on Sep 4, 2013
  1. @damienstuart

    Updated Perl FKO tests for lastest changes to libfko. Fixed bug where…

    … $fko->hmac() was always returning -1.
    damienstuart committed Sep 4, 2013
Commits on Aug 29, 2013
  1. Merge pull request #105 from fjoncourt/master

    Make sure log_msg() sends messages to STDERR until the context gets initialized.
    committed Aug 28, 2013
Commits on Aug 27, 2013
  1. Fixed *Value stored is never read* warning found by clang.

    Franck Joncourt committed Aug 27, 2013
  2. Make sure all calls to log_msg() send messages to STDERR until the co…

    …nfig files are parsed.
    Franck Joncourt committed Aug 27, 2013
Commits on Aug 19, 2013
  1. Added AppArmor policy

    This commit adds an AppArmor policy that is known to work in Debian and Ubuntu
    systems.  The original version of this policy was contributed by Radostan Riedel
    to the fwknop mailing list.
    committed Aug 18, 2013
  2. [server] fix crash if replay digest tracking init() fails

    This commit fixes a crash if the replay digest init() routine fails - fwknopd
    attempted to make use of replay tracking anyway.  The crash was discovered
    during testing fwknopd with an AppArmor enforce policy deployed.  The
    following stack trace shows the crash (taken before the previous static
    function commit):
     Program received signal SIGSEGV, Segmentation fault.
     __strlen_sse2 () at ../sysdeps/x86_64/multiarch/../strlen.S:31
     31      ../sysdeps/x86_64/multiarch/../strlen.S: No such file or directory.
     (gdb) where
     #0  __strlen_sse2 () at ../sysdeps/x86_64/multiarch/../strlen.S:31
     #1  0x00007f59cabd8b26 in add_replay_file_cache (opts=opts@entry=0x7fff3eaa0bb0, digest=digest@entry=0x0) at replay_cache.c:516
     #2  0x00007f59cabd8cf5 in add_replay (opts=opts@entry=0x7fff3eaa0bb0, digest=digest@entry=0x0) at replay_cache.c:472
     #3  0x00007f59cabd62eb in incoming_spa (opts=0x7fff3eaa0bb0) at incoming_spa.c:536
     #4  0x00007f59ca56164e in ?? () from /usr/lib/x86_64-linux-gnu/
     #5  0x00007f59cabd7175 in pcap_capture (opts=opts@entry=0x7fff3eaa0bb0) at pcap_capture.c:269
     #6  0x00007f59cabd3d4d in main (argc=5, argv=0x7fff3eaa1458) at fwknopd.c:314
    committed Aug 18, 2013
Commits on Aug 18, 2013
  1. [test suite] added 'make test' check for FKO perl module

    All built-in tests in the FKO module must pass for this new test to pass.  This commit
    is in support of #103
    committed Aug 17, 2013
Commits on Aug 13, 2013
  1. @damienstuart

    First round of updates to get the Perl module up-to-date with the new…

    … libfko. Added new error refs and commented out bad/invalid tests.
    damienstuart committed Aug 12, 2013
Commits on Aug 12, 2013
  1. Added fko context dumper change to ChangeLog, updated test suite to a…

    …ccount for single line printing of final SPA data
    committed Aug 11, 2013
Something went wrong with that request. Please try again.