Tensor init syntax change #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
newTensor(shape: openarray[int], T: typedesc)for
newTensor[T](shape: varargs[int])This allows the new
let a = newTensor[int](5,3)as well asnewTensor[int]([5,3])Furthermore proc[T]() is nim idiom, old syntax was used as a workaround for something I don't remember.
Issue: deprecated warning rampage, reported upstream: nim-lang/Nim#6436
Shorter name newSeqUninitialized --> newSeqUninit
replace newTensor from Use non initialized seqs where appropriate #64 by newTensorUninit (for uninitialized) and bring back the old behavior (init with default value).
Also replace tensorCpu + newSeqUninit by a single newTensorUninit
newTensor with value is changed to newTensorWith (mirror sequtils)
cc @edubart : Beware before pulling master. I'm pushing that in 3-4 hours