Mass rename of step to time in implementation #375
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No new features, but a fairly painful rename here.
For mode models we need to work in terms of "time", but for dust models we used "step". Seemed like a good idea at the time. However, this causes all sorts of pain in getting a uniform interface for both model types, and there is more of a concept of time in a discrete time model than there is a concept of step in an ode model so dust should be the one to change.
I've added a little explanatory section in dust_generator.R (via the template)
Before this can be merged I need to prepare PRs to adapt dependent packages:
No changes required to:
There's another change to make at some point where we replace "step" with "time" within odin discrete time models to complete this, but that's an even more disruptive change that might be hard to make
This is ready for review, but probably best to consider all at once - particularly the odin.dust and mcstate ones