Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mrc-2752 Expect errors from calibrate endpoint because calibrate id is not valid #594

Merged
merged 2 commits into from Nov 9, 2021

Conversation

EmmaLRussell
Copy link
Contributor

@EmmaLRussell EmmaLRussell commented Nov 9, 2021

Description

I think this build error was due to the dummy calibrate endpoint having been relaxed about accepting any calibrate id. The tests pass a fake calibrate id, and this now causes an error, as it does when fake id is passed for calibrate result. I have updated the tests to be consistent with the calibrate result tests .i.e. pass fake id, and expect an error. It would be good to test the success case if and when we get browser testing added to HINT.

Type of version change

Delete as appropriate

None

Checklist

  • I have incremented version number, or version needs no increment
  • The build passed successfully, or failed because of ADR tests

@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #594 (c798c5b) into master (cb069b2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             master   #594   +/-   ##
=======================================
  Coverage        98%    98%           
  Complexity      275    275           
=======================================
  Files           191    191           
  Lines          5530   5530           
  Branches        775    775           
=======================================
  Hits           5434   5434           
  Misses           61     61           
  Partials         35     35           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb069b2...c798c5b. Read the comment docs.

@EmmaLRussell EmmaLRussell requested review from Nicolas-Dolan, mwoodbri, hillalex and LekanAnni and removed request for mwoodbri November 9, 2021 12:29
Copy link
Contributor

@LekanAnni LekanAnni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EmmaLRussell EmmaLRussell merged commit 019023c into master Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants