Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache models #54

Closed
richfitz opened this issue Nov 1, 2016 · 4 comments
Closed

Cache models #54

richfitz opened this issue Nov 1, 2016 · 4 comments
Labels
Projects
Milestone

Comments

@richfitz
Copy link
Member

@richfitz richfitz commented Nov 1, 2016

If the code has not changed, we could get away with retrieving the model from a cache. This would make using odin::odin within a function more reasonable.

@richfitz
Copy link
Member Author

@richfitz richfitz commented Mar 14, 2017

See #62 and #63

@richfitz richfitz modified the milestone: release Mar 14, 2017
@richfitz richfitz added the interface label Mar 15, 2017
@richfitz
Copy link
Member Author

@richfitz richfitz commented Mar 21, 2017

This probably requires a preprocessing step to pull out the config lines because a hash would need to include the hash of the includes and need to deal with the basename (to determine what files to compare with)

@richfitz
Copy link
Member Author

@richfitz richfitz commented Jan 5, 2018

@richfitz
Copy link
Member Author

@richfitz richfitz commented Jan 5, 2018

Issues to deal with here:

  • pool of models
  • expire old models and unload the dll to avoid hitting limit (default is 100, tunable to 1000 on startup by setting R_MAX_NUM_DLLS, and only if the number of available fds is high enough)
  • when expiring models need to remove and gc and pointers created by each generator
@richfitz richfitz added this to To Do in development Jan 11, 2018
@richfitz richfitz moved this from To Do to In progress in development Jan 11, 2018
@richfitz richfitz moved this from In progress to To Do in development Jan 11, 2018
@richfitz richfitz closed this in 6c016d2 Jan 18, 2018
development automation moved this from To Do to Done Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
development
  
Done
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.