Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unload DLLs automatically #64

Closed
richfitz opened this issue Mar 3, 2017 · 3 comments
Closed

Unload DLLs automatically #64

richfitz opened this issue Mar 3, 2017 · 3 comments
Labels
Projects

Comments

@richfitz
Copy link
Member

@richfitz richfitz commented Mar 3, 2017

If running interactively, get the generator to store references to the models that have been created with it, set them to destruct with a finaliser and then that means we can tell when a DLL can be unloaded automatically

@richfitz richfitz added the interface label Mar 15, 2017
@richfitz
Copy link
Member Author

@richfitz richfitz commented Mar 21, 2017

This is only an issue when running interactively with odin::odin; we can save copies of the DLL that we create into a general cache and then save copies of models that are generated from that into another cache. Garbage collection then looks like checking that the pointer has been cleared and if so marking the DLL as unloadable, then unloading it

@richfitz richfitz added this to To Do in development Jan 11, 2018
@richfitz
Copy link
Member Author

@richfitz richfitz commented Feb 6, 2018

I forget what the use case is here. I think that it's for people who hit the max loaded dlls limit

@richfitz
Copy link
Member Author

@richfitz richfitz commented Jun 20, 2018

This will likely be an issue with odin.ui

  • cache needs to become a ring so that things drop off the end
  • then add a finaliser to the R6 class for cleanup, but disable this in package code
@richfitz richfitz moved this from To Do to Up next in development Jun 20, 2018
richfitz added a commit that referenced this issue Jun 25, 2018
Fixes #129, #64
richfitz added a commit that referenced this issue Sep 19, 2018
richfitz added a commit that referenced this issue Mar 14, 2019
Fixes #64
@richfitz richfitz mentioned this issue Mar 15, 2019
@richfitz richfitz closed this in a95f96c Apr 8, 2019
development automation moved this from Up next to Done Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
development
  
Done
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.