New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I139 ir #156
Conversation
Codecov Report
@@ Coverage Diff @@
## master #156 +/- ##
========================================
+ Coverage 99.3% 100% +0.69%
========================================
Files 22 37 +15
Lines 3592 4388 +796
========================================
+ Hits 3567 4388 +821
+ Misses 25 0 -25
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #156 +/- ##
========================================
+ Coverage 99.3% 100% +0.69%
========================================
Files 22 38 +16
Lines 3591 4455 +864
========================================
+ Hits 3566 4455 +889
+ Misses 25 0 -25
Continue to review full report at Codecov.
|
Avoid annoying NULL substitution errors by making them explicit
Not yet complete; still need to add allocations
Not a big difference for small models, for large models such as cotonou (1,400 nodes) this is about 1s faster
Fixes #75
There will be a big documentation push soon
Codecov Report
@@ Coverage Diff @@
## master #156 +/- ##
========================================
+ Coverage 99.3% 100% +0.69%
========================================
Files 22 38 +16
Lines 3591 4458 +867
========================================
+ Hits 3566 4458 +892
+ Misses 25 0 -25
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #156 +/- ##
========================================
+ Coverage 99.3% 100% +0.69%
========================================
Files 22 38 +16
Lines 3591 4474 +883
========================================
+ Hits 3566 4474 +908
+ Misses 25 0 -25
Continue to review full report at Codecov.
|
A complete rewrite of the odin engine, designed to increase future maintainability but have few user-visible effects. In brief, this does add
target = "r"
to use this.This does introduce a few user-visible breaking changes:
x[] <- i
) produces output that is off-by-one compared with the previous version (see #136)odin()
have been modified slightlyodin_package()
no longer supports multi-file mode (I don't think this was ever used).user
are validated and providing additional parameters is an error