Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Providing setupFile causes run failure #34

Closed
soumyamahunt opened this issue Jan 9, 2022 · 4 comments · Fixed by #35
Closed

Providing setupFile causes run failure #34

soumyamahunt opened this issue Jan 9, 2022 · 4 comments · Fixed by #35

Comments

@soumyamahunt
Copy link
Contributor

soumyamahunt commented Jan 9, 2022

If setupFile is provided in config, action is failing with error Error: join is not defined, on looking into changelog.js it is missing import for join function.

@mrchief
Copy link
Owner

mrchief commented Jan 12, 2022

join is a native function so there's nothing to import. I think the problem lies elsewhere.

@soumyamahunt
Copy link
Contributor Author

soumyamahunt commented Jan 12, 2022

native function

I think the join function you have shared is for array, but the function in code is for path:

const setup = require(join(process.cwd(), setupFile))
.

@mrchief
Copy link
Owner

mrchief commented Jan 14, 2022

I think the join function you have shared is for array

That's because the line you referred to in your original comment is producing a JS array. 😄

I see that you updated your comment and yes, it requires a import for the one you pointed out in your latest.

@soumyamahunt
Copy link
Contributor Author

I think the join function you have shared is for array

That's because the line you referred to in your original comment is producing a JS array. 😄

I see that you updated your comment and yes, it requires a import for the one you pointed out in your latest.

Yeah the original issue didn't contain link to the exact line (instead it pointed to just the file), I guess that was causing confusion 😄.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants