Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set "Vary: Accept-Encoding" header only if encoding is set and not empty #642

Merged
merged 1 commit into from Sep 19, 2019

Conversation

@csabahete
Copy link

commented Nov 6, 2018

I noticed that in the options provided for the constructor of HTTP_ConditionalGet the encoding option could never be null causing the "Vary: Accept-Encoding" header to be always sent. By this change it will only be set if the encoding has a value different than the empty string.

@glensc

This comment has been minimized.

Copy link
Collaborator

commented Jan 16, 2019

not sure what you mean...

you mean that second if is superfluous?

if (isset($spec['encoding'])) {
            if ('' !== $spec['encoding']) {
@glensc glensc merged commit 807f419 into mrclay:master Sep 19, 2019
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.