Specify that the greatest version we can support of the activerecord-jdbc-adapter is 1.2.9.1 #16

Merged
merged 1 commit into from Jan 7, 2014

Conversation

Projects
None yet
2 participants

I had been doing some work and testing with a clean install of JRuby, and when I did a 'bundle install' that included the latest version of the activerecord-jdbcteradata-adapter (0.5.1), I was finding that even basic INSERT and SELECT operations were not working properly.

I found that the root cause of this issue was that the gemspec for activerecord-jdbcteradata-adapter 0.5.1 adds a dependency on 'activerecord-jdbc-adapter', but does not specify a specific version number for that dependency, so by default, the most recent version is fetched.

It seems there have been some major (breaking) changes in the 1.3.x line of 'activerecord-jdbc-adapter', for which the specs for this AR JDBC Teradata adapter no longer pass.. While it probably makes sense at some point to dig through and make this AR JDBC Teradata adapter compatible with the 1.3.x line of the AR JDBC Adapter, for right now, a quick fix is to just specify that the latest version of the AR JDBC Adapter that is supported is 1.2.9.1. With this in place, the specs all pass.

Rob Goretsky Specify that the greatest version we can support of the activerecord-…
…jdbc-adapter is 1.2.9.1. The 1.3.x line of the activerecord-jdbc-adapter introduces changes that break the functionality of this adapter
7391f8e

@mrcsparker mrcsparker added a commit that referenced this pull request Jan 7, 2014

@mrcsparker mrcsparker Merge pull request #16 from RobGoretsky/set_ar_jdbc_version_to_1_2_9_1
Specify that the greatest version we can support of the activerecord-jdbc-adapter is 1.2.9.1
810c15d

@mrcsparker mrcsparker merged commit 810c15d into mrcsparker:master Jan 7, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment