From 3757ded434e4cde88a86f07a62ef635ff7edf3c3 Mon Sep 17 00:00:00 2001 From: yuhan Date: Mon, 1 Feb 2021 15:02:40 -0800 Subject: [PATCH] add dagster-azure back to dev_install Summary: https://github.com/dagster-io/dagster/issues/3573 https://github.com/dagster-io/dagster/pull/2483#issuecomment-635174157 Test Plan: in fresh virtualenv ``` ~/dev/dagster arcpatch-D6207 $ make dev_install ~/dev/dagster arcpatch-D6207 $ test-D6207 $ pip freeze | grep azure azure-common==1.1.26 azure-core==1.10.0 azure-storage-blob==12.3.2 azure-storage-file-datalake==12.0.2 -e git+git@github.com:dagster-io/dagster.git@bd35c74ff476078799a55650d70fa5c28b43d373#egg=dagster_azure&subdirectory=python_modules/libraries/dagster-azure ~/dev/dagster/docs arcpatch-D6207 test-D6207 $ make buildnext && cd next && yarn && yarn dev ``` {F536160} Reviewers: sashank, nate, sandyryza Reviewed By: nate, sandyryza Differential Revision: https://dagster.phacility.com/D6207 --- scripts/install_dev_python_modules.py | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/scripts/install_dev_python_modules.py b/scripts/install_dev_python_modules.py index 4acd7566febd..f71ab4347bc9 100644 --- a/scripts/install_dev_python_modules.py +++ b/scripts/install_dev_python_modules.py @@ -84,14 +84,10 @@ def main(quiet): "-e python_modules/libraries/lakehouse", "-e integration_tests/python_modules/dagster-k8s-test-infra", "-r scala_modules/scripts/requirements.txt", + "-e python_modules/libraries/dagster-azure", # # https://github.com/dagster-io/dagster/issues/3488 # "-e python_modules/libraries/dagster-airflow", - # - # https://github.com/dagster-io/dagster/pull/2483#issuecomment-635174157 - # Uncomment only when snowflake-connector-python can be installed with optional (or - # compatible) Azure dependencies. - # "-e python_modules/libraries/dagster-azure", ] # dagster-ge depends on a great_expectations version that does not install on Windows