Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Small fixes #7

Merged
merged 2 commits into from

2 participants

Erik Faye-Lund Mr.doob
Erik Faye-Lund

Seems I accidentally broke the show/hide code button, so here's a fix. I also included a patch to show linker errors, if any.

kusma added some commits
Erik Faye-Lund kusma fix hiding/showing code
It seems I had a bit of fat fingers myself; I accidentally broke
the "[hide|show] code" button when I changed codemirror2... Fix
it again!
39e788e
Erik Faye-Lund kusma display linker errors 87931a2
Mr.doob mrdoob merged commit 87931a2 into from
Mr.doob
Owner

True. I should have tested that... -_-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Dec 1, 2011
  1. Erik Faye-Lund

    fix hiding/showing code

    kusma authored
    It seems I had a bit of fat fingers myself; I accidentally broke
    the "[hide|show] code" button when I changed codemirror2... Fix
    it again!
  2. Erik Faye-Lund

    display linker errors

    kusma authored
This page is out of date. Refresh to see the latest.
Showing with 9 additions and 3 deletions.
  1. +1 −0  static/css/codemirror.css
  2. +8 −3 static/index.html
1  static/css/codemirror.css
View
@@ -10,6 +10,7 @@
font-family: monospace;
font-size: 14px;
font-weight: bold;
+ visibility: visible;
}
.CodeMirror:hover {
11 static/index.html
View
@@ -193,10 +193,10 @@
button.textContent = 'hide code';
button.addEventListener( 'click', function ( event ) {
- if ( code.style.visibility === 'visible' ) {
+ if ( code.getWrapperElement().style.visibility === 'visible' ) {
button.textContent = 'show code';
- code.style.visibility = 'hidden';
+ code.getWrapperElement().style.visibility = 'hidden';
select.style.visibility = 'hidden';
compileButton.style.visibility = 'hidden';
set_save_button('hidden');
@@ -204,7 +204,7 @@
} else {
button.textContent = 'hide code';
- code.style.visibility = 'visible';
+ code.getWrapperElement().style.visibility = 'visible';
select.style.visibility = 'visible';
compileButton.style.visibility = 'visible';
set_save_button('visible');
@@ -313,6 +313,11 @@
if ( !gl.getProgramParameter( program, gl.LINK_STATUS ) ) {
+ var error = gl.getProgramInfoLog( program );
+
+ compileButton.title = error;
+ console.error( error );
+
console.error( 'VALIDATE_STATUS: ' + gl.getProgramParameter( program, gl.VALIDATE_STATUS ), 'ERROR: ' + gl.getError() );
compileButton.style.color = '#ff0000';
compileButton.textContent = 'compiled with errors';
Something went wrong with that request. Please try again.