New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spot & Directional targets are redundant #5870

Closed
QuaziKb opened this Issue Jan 7, 2015 · 6 comments

Comments

Projects
None yet
5 participants
@QuaziKb

QuaziKb commented Jan 7, 2015

why do spot and directional lights have a particular object they point towards at all times, instead of use their own transform? It's strange that spot and directional lights use Object3D, yet their rotation is completely useless, and they opt instead to have an extra positioned object. If the goal was to make positioning / pointing the lights simpler, it didn't really work, since Object3D can already easily point towards a position using lookAt.

This is not truly an issue, but weird from an api standpoint, and makes adding a spotlight as something like a headlight extra annoying. Of course there are probably workarounds like adding the target to the light object but it just always seemed strange, and more complex than it could ever make something simpler.

@WestLangley

This comment has been minimized.

Show comment
Hide comment
@WestLangley

WestLangley Jan 8, 2015

Collaborator

For reference, and some history on this issue, see: #2251, #3497, #4261, #5079, and #5555.

Collaborator

WestLangley commented Jan 8, 2015

For reference, and some history on this issue, see: #2251, #3497, #4261, #5079, and #5555.

@QuaziKb QuaziKb changed the title from Spot & Directional targets is redundant to Spot & Directional targets are redundant Jan 8, 2015

@QuaziKb

This comment has been minimized.

Show comment
Hide comment
@QuaziKb

QuaziKb Jan 8, 2015

I can't really see what the advantage of having the target is, or really what it's changing with the shadow-map. When i move it from super close to super far, using the same direction, the shadow map looks entirely the same.

QuaziKb commented Jan 8, 2015

I can't really see what the advantage of having the target is, or really what it's changing with the shadow-map. When i move it from super close to super far, using the same direction, the shadow map looks entirely the same.

@mrdoob mrdoob added the Suggestion label Jan 8, 2015

@mrdoob

This comment has been minimized.

Show comment
Hide comment
@mrdoob

mrdoob Jan 8, 2015

Owner

Totally agreed. We're in the process of removing those targets.
I think @gero3 tried some time ago but the PR was unfinished.

Owner

mrdoob commented Jan 8, 2015

Totally agreed. We're in the process of removing those targets.
I think @gero3 tried some time ago but the PR was unfinished.

@looeee

This comment has been minimized.

Show comment
Hide comment
@looeee

looeee Dec 15, 2016

Collaborator

@mrdoob is there still an intention to remove these targets?

In the meantime information on how they currently work has been added to the docs.

Collaborator

looeee commented Dec 15, 2016

@mrdoob is there still an intention to remove these targets?

In the meantime information on how they currently work has been added to the docs.

@mrdoob

This comment has been minimized.

Show comment
Hide comment
@mrdoob

mrdoob Dec 16, 2016

Owner

@mrdoob is there still an intention to remove these targets?

Yep!

Owner

mrdoob commented Dec 16, 2016

@mrdoob is there still an intention to remove these targets?

Yep!

@donmccurdy

This comment has been minimized.

Show comment
Hide comment
@donmccurdy

donmccurdy Aug 4, 2018

Collaborator

Closing as duplicate of #5079.

Collaborator

donmccurdy commented Aug 4, 2018

Closing as duplicate of #5079.

@donmccurdy donmccurdy closed this Aug 4, 2018

@donmccurdy donmccurdy added the Duplicate label Aug 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment