New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd Texture Issue in r72 #7197

Closed
titansoftime opened this Issue Sep 20, 2015 · 18 comments

Comments

Projects
None yet
3 participants
@titansoftime
Contributor

titansoftime commented Sep 20, 2015

I'm not really sure what's going on here, but you can see in this fiddle:

http://jsfiddle.net/titansoftime/pawthzr8/

that the texture is a little distorted. This is the only one (that I know of) out of several hundred of our models that has been affected.

This started in r72, it was fine previously.

You can get the model here: http://www.titansoftime.com/utils.php?task=getModel&id=71
And the texture: http://www.titansoftime.com/textures/71_1024.dds

@mrdoob

This comment has been minimized.

Owner

mrdoob commented Sep 21, 2015

Is it a problem with the model or the texture? Have you tried with a non-dds texture instead?

@titansoftime

This comment has been minimized.

Contributor

titansoftime commented Sep 21, 2015

I will give it a shot when I get home from work. Interesting to test, though in production not using a compressed texture is not really an option.

@mrdoob

This comment has been minimized.

Owner

mrdoob commented Sep 21, 2015

Something I've just tried... I've tried loading the model in the editor and use a random texture in the map slot. Then, in the project panel, I switched the renderer to CanvasRenderer.

CanvasRenderer doesn't do the new THREE.BufferGeometry().fromGeometry() so I was double checking if there was a bug there... Seems like that part is fine.

Did you updated the DDSLoader?

@titansoftime

This comment has been minimized.

Contributor

titansoftime commented Sep 21, 2015

@mrdoob

This comment has been minimized.

Owner

mrdoob commented Sep 21, 2015

Ah, true.

@titansoftime

This comment has been minimized.

Contributor

titansoftime commented Sep 22, 2015

This issue does not exist with skinning disabled.

http://jsfiddle.net/titansoftime/53rqpdfv/

Just like #7111. Hmm...

@mrdoob

This comment has been minimized.

Owner

mrdoob commented Sep 22, 2015

Updated links to use r72 instead of r73dev:

http://jsfiddle.net/pawthzr8/2/
http://jsfiddle.net/53rqpdfv/2/

@titansoftime

This comment has been minimized.

Contributor

titansoftime commented Oct 12, 2015

@mrdoob Do you have any idea what caused this bug?

All I know (thanks to the observation of @arose) is that this issue only affects a material with skinning enabled. Please whoever broke this, take a look at it. I don't even know where to begin, not to mention r72 has a billion commits.

Can we at least get a bug label on this?

@mrdoob mrdoob added the Bug label Oct 12, 2015

@mrdoob

This comment has been minimized.

Owner

mrdoob commented Nov 21, 2015

@titansoftime have you tried updating the code to the new animation system?

@titansoftime

This comment has been minimized.

Contributor

titansoftime commented Nov 21, 2015

I have and unfortunately the issue remains (74dev). It's been a little while so I'd like to reiterate that setting material.skinning to false "fixes" this and #7111.

@mrdoob

This comment has been minimized.

Owner

mrdoob commented Nov 21, 2015

Do you mind updating the jsfiddles to r74dev? 😇

@titansoftime

This comment has been minimized.

Contributor

titansoftime commented Nov 23, 2015

Here you are: http://jsfiddle.net/eo0hpjk5/

Old expected behaviour (r71): http://jsfiddle.net/fnanr01f/

I updated the fiddles for #7111 as well.

@WestLangley

This comment has been minimized.

Collaborator

WestLangley commented Nov 23, 2015

Can you reduce your model to just the flag? Or better yet, reproduce the issue with a single quad?

@titansoftime

This comment has been minimized.

Contributor

titansoftime commented Nov 23, 2015

Can you reduce your model to just the flag? Or better yet, reproduce the issue with a single quad?

Unfortunately no. I am not an animator or a modeler. I paid for all my models / animations.

@mrdoob

This comment has been minimized.

Owner

mrdoob commented Nov 24, 2015

If you don't convert to BufferGeometry it seems to render just fine:

http://jsfiddle.net/eo0hpjk5/1/

@mrdoob

This comment has been minimized.

Owner

mrdoob commented Nov 24, 2015

My bet is that SkinnedMesh.normalizeSkinWeights() expects skinWeights to be normalized when using BufferGeometry.

@WestLangley

This comment has been minimized.

Collaborator

WestLangley commented Nov 24, 2015

Looks much better if weights are normalized prior to converting to BufferGeometry.

r.74dev: http://jsfiddle.net/eo0hpjk5/2/
r.71: http://jsfiddle.net/fnanr01f/

However, now notice that there are slight differences in the animations between versions.

@titansoftime

This comment has been minimized.

Contributor

titansoftime commented Nov 25, 2015

Closing due to the cause of issue being on track to be fixed in #7111.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment