ImageLoader crossOrigin support #10168

Merged
merged 1 commit into from Nov 19, 2016

Projects

None yet

3 participants

@takahirox
Contributor

This PR enables ImageLoader support crossOrigin.
See #10099

@mrdoob mrdoob merged commit 09b634d into mrdoob:dev Nov 19, 2016
@mrdoob
Owner
mrdoob commented Nov 19, 2016

Thanks!

@takahirox takahirox deleted the takahirox:ImageLoaderCrossOrigin branch Nov 19, 2016
@customlogic
Contributor

This introduces a bug. The "this.path" variable is ignored when creating the URL to load

Owner

/ping @takahirox

Owner

I'm thinking of reverting to not using FileLoader inside ImageLoader. So far...

  1. Some people relied on image.src being a file path
  2. SVG now has mime type issues
  3. CrossOrigin issues
Contributor

Oops, that's right.
I'll fix soon.
Thanks @customlogic !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment