HemisphereLightHelper: Refactoring #10205

Merged
merged 1 commit into from Nov 23, 2016

Projects

None yet

2 participants

@Mugen87
Contributor
Mugen87 commented Nov 23, 2016 edited
  • usage of OctahedronBufferGeometry instead of SphereGeometry
  • renamed sphereSize to size
  • removed lightSphere from public interface

I hope nobody loses a foot with this PR! ๐Ÿ˜‰

Besides, if this PR gets merged, all helpers are based on BufferGeometry (yay๐ŸŽ‰).

@Mugen87
Contributor
Mugen87 commented Nov 23, 2016 edited
@mrdoob
Owner
mrdoob commented Nov 23, 2016 edited

I hope nobody loses a foot with this PR! ๐Ÿ˜‰

Haha!

Besides, if this PR gets merged, all helpers are based on BufferGeometry (yay๐ŸŽ‰).

๐ŸŽ‰๐ŸŽ‰๐ŸŽ‰

@mrdoob mrdoob merged commit 8bbaffa into mrdoob:dev Nov 23, 2016
@mrdoob
Owner
mrdoob commented Nov 23, 2016 edited

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment