Cylindrical: Support for Cylindrical Coordinates #10253

Merged
merged 2 commits into from Nov 30, 2016

Projects

None yet

3 participants

@Mugen87
Contributor
Mugen87 commented Nov 30, 2016 edited

This PR adds basic support for cylindrical coordinates (analogous to Spherical).

https://en.wikipedia.org/wiki/Cylindrical_coordinate_system

@Mugen87
Contributor
Mugen87 commented Nov 30, 2016

The notation of the components is currently: radius, theta, y. In some sources i've seen rho instead of radius and height instead of y. Not sure if these names fit better...

@WestLangley
Collaborator

I think you should add Vector3.setFromCylindrical( c ).

Your notation looks fine to me.

@Mugen87
Contributor
Mugen87 commented Nov 30, 2016

Done!

@mrdoob
Owner
mrdoob commented Nov 30, 2016

Looks good! Thanks!

@mrdoob mrdoob merged commit 984a140 into mrdoob:dev Nov 30, 2016
@mrdoob
Owner
mrdoob commented Nov 30, 2016

Any chance you could implement both Cylindrical and Spherical wherever you find fitting in the examples?

@Mugen87
Contributor
Mugen87 commented Nov 30, 2016

Okay, i will have a look. If somebody else finds an appropriate example or use case, just post it here.

@Mugen87
Contributor
Mugen87 commented Dec 3, 2016 edited

The display of elements in css3d_periodictable as a sphere or helix is now done via Spherical/Cylindrical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment