MeshNormalMaterial improvements #10343

Merged
merged 2 commits into from Dec 15, 2016

Projects

None yet

3 participants

@WestLangley
Collaborator
WestLangley commented Dec 12, 2016 edited

Continuation of #10330

Fixed some bugs. Added support for normal/bump/displacement maps, flat shading, morphs, skinning.

Removed support for clipping ( at least for now ) as the chunk if-defs are becoming more and more difficult to get right. I am not sure clipping is a big deal for this material, anyway, as it is primarily a diagnostic tool.

/ping @bhouston

@WestLangley
Collaborator

Hmm. I miss threejsworker. Here is a screenshot.

screen shot 2016-12-12 at 5 08 34 pm

@bhouston
Contributor

Very nice. :) I think this is great. And all the new features are optional too so that is great. This will allow for effects like SAO and SSAO to produce better results on models who represent their normals using normal or bump maps. I can not wait to try it out. Thank you @WestLangley

@WestLangley
Collaborator

@bhouston This PR was the last straw. I am going to take a stab at implementing #9035. : - )

@mrdoob mrdoob merged commit 9efe29a into mrdoob:dev Dec 15, 2016
@mrdoob
Owner
mrdoob commented Dec 15, 2016

Thanks thanks!

@mrdoob
Owner
mrdoob commented Dec 15, 2016

I am going to take a stab at implementing #9035. : - )

Yay!

@WestLangley WestLangley deleted the WestLangley:dev-normal_material branch Dec 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment