Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GridHelper: Size parameter is now correctly handled #10570

Merged
merged 3 commits into from Jan 16, 2017

Conversation

@Mugen87
Copy link
Collaborator

commented Jan 13, 2017

This PR adresses #10409.

A grid with size of 10 is now equal to a PlaneGeometry with widht/height of 10.

@WestLangley

This comment has been minimized.

Copy link
Collaborator

commented Jan 13, 2017

Thanks. Update examples, too?

@Mugen87

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 13, 2017

Of course! I forgot about it.

@Mugen87

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 14, 2017

Done!

@mrdoob mrdoob merged commit 429a030 into mrdoob:dev Jan 16, 2017

@mrdoob

This comment has been minimized.

Copy link
Owner

commented Jan 16, 2017

Thanks!

@looeee

This comment has been minimized.

Copy link
Collaborator

commented Jan 25, 2017

@Mugen87 regarding the docs for this, if I do:

var gridHelper = new THREE.GridHelper( 10 );

this will create a 20x20 square grid centred at (0, 0, 0). Correct?

@Mugen87

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 25, 2017

See http://jsfiddle.net/2zvfzuL7/1/

var gridHelper = new THREE.GridHelper( 10 );

will produce a 10x10 grid.

@looeee

This comment has been minimized.

Copy link
Collaborator

commented Jan 25, 2017

Ah great! I think that should count as "expected behaviour" 😁
I'll leave the docs as they are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.