Kkruups dev1 #12146
Merged
Kkruups dev1 #12146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added comments to better understand file parser and data structures in more detail.
Code before fix was extracting 4-bits from 1st utf8 Byte instead of 5 bits, resulting in 10-bit binary number instead of 11-bit as specified for Double Byte.
This reverts commit 6e0892b.
|
Seems like it's already fixed in https://github.com/creationix/msgpack-js-browser/blob/master/msgpack.js. I'll pull after merging this. |
|
Thanks! |
|
Yes, I had submitted PR fix to @creationix as well. BR/Kk |
|
Thanks! :) |
|
I see I see! Double thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per @mrdoob, attempted to make change directly.
However, direct edit resulted in having to create new PR, since no direct edit rights.
BR/KK