Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix non power-of-2 textures being flipped when resized #15904
I did more research on this over the weekend. Also in conversations with the WebGL team at Chrome. It's not clear if
Until that is resolved, I realised we can just pass the OffscreenCanvas to gl directly.
Can you change this PR so it just changes this line from this:
return useOffscreenCanvas ? canvas.transferToImageBitmap() : canvas;
What browser/os did you try that on? I can still reproduce in Chrome/OSX.
I haven't perfectly read through the conversation here and in #15896 but I just want to comment that returning canvas may be safer as this PR finally goes than converting to
As I'm adding a note to
The upside down problem mentioned above might come from this? I guess
Similarly saying, internally converting
Update: perhaps it should be rendered upside down because