Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSM: Added TS files for OBJLoader2 and fix style issues. #16969

Merged
merged 2 commits into from Jul 8, 2019

Conversation

Projects
None yet
3 participants
@Mugen87
Copy link
Collaborator

commented Jul 3, 2019

The TS type declaration files for OBJLoader2 were lately requested in the forum (see here).

The PR also fixes all code styles issues in the OBJLoader2 code base.

/cc @kaisalmen

@Mugen87 Mugen87 added this to the r107 milestone Jul 3, 2019

@kaisalmen

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2019

@Mugen87 Thank you, I will review the ts files over the weekend. Did you create them (semi-)automatically and if so how or manually? Regarding formatting, I guess I need to do my homework. 😅 Are there any configuration files available for jslint ode IDE configuration (WebStorm/VSCode)? Any hints are welcome. Thanks

@kaisalmen

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2019

Btw, ping me in the forum when I could be of help and don't notice it myself.

@Mugen87

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 4, 2019

Btw, ping me in the forum when I could be of help and don't notice it myself.

Okay! And yeah, I've written the TS declaration files manually^^.

@Mugen87

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 8, 2019

Merging for now. Feel free to create a new PR with fixes/improvements.

@Mugen87 Mugen87 merged commit 7af245c into mrdoob:dev Jul 8, 2019

2 checks passed

LGTM analysis: JavaScript No new or fixed alerts
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mrdoob

This comment has been minimized.

Copy link
Owner

commented Jul 10, 2019

Thanks!

@kaisalmen

This comment has been minimized.

Copy link
Contributor

commented Jul 10, 2019

@Mugen87 thanks again for you work. I overlook that some public functions are not properly documented in the js files. I started polishing this and will perform minor changes to the ts files where required. PR will come later...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.