Implemented Path.ellipse #1879

Merged
merged 1 commit into from May 26, 2012

Projects

None yet

5 participants

@linzhp
linzhp commented May 8, 2012

Implemented the feature needed in #1870, refactored Path.arc related code. Now it is able to draw ellipses without relying on bezierCurveTo.

@zz85 Please review. Thanks!

@linzhp linzhp referenced this pull request in zz85/three.js May 17, 2012
Merged

Implemented Path.ellipse #1

@mrdoob
Owner
mrdoob commented May 19, 2012

@zz85 what do you think?

@zz85
zz85 commented May 19, 2012

i haven't managed to try this out myself personally, but i think it looks fine!

@mrdoob mrdoob merged commit b8ee478 into mrdoob:dev May 26, 2012
@mrdoob
Owner
mrdoob commented May 26, 2012

Merged! Sorry for the delay :S

@linzhp
linzhp commented May 26, 2012

No problem! I am glad my changes were accepted

@zz85
zz85 commented Jul 13, 2012

ohoh, after reverting many commit logs I just realized that this merge just broke examples/webgl_geometry_shapes.html a little...

@zz85 zz85 referenced this pull request Jul 13, 2012
Closed

CurvePath geometry issue #2157

@alteredq

ohoh, after reverting many commit logs I just realized that this merge just broke examples/webgl_geometry_shapes.html a little...

Is it about smiley face and disc with hole in the center being broken?

I just merged your geometry.mergeVertices fix and noticed these.

@zz85
zz85 commented Jul 17, 2012

yes, is it. haven't gotten down to see whether went wrong..

Is it about smiley face and disc with hole in the center being broken?

@zz85 zz85 added a commit to zz85/three.js that referenced this pull request Jul 19, 2012
@zz85 zz85 Fixes relating to #1879 and possibly #1501
- Path.js (esp. Arcs) is still confusing, but as of now
- Ellipses should work
- Path still uses "PATH.ACTIONS"
- the internal curve representation doesn't seem to be used yet
- Path.arc() uses .absarc() which uses .absellipse()
- examples/webgl_geometry_shapes.html should run now
2ceae00
@wvl wvl pushed a commit to wvl/three.js that referenced this pull request Nov 28, 2012
@zz85 zz85 (threejs src) Fixes relating to #1879 and possibly #1501
- Path.js (esp. Arcs) is still confusing, but as of now
- Ellipses should work
- Path still uses "PATH.ACTIONS"
- the internal curve representation doesn't seem to be used yet
- Path.arc() uses .absarc() which uses .absellipse()
- examples/webgl_geometry_shapes.html should run now
7136106
@em
em commented Sep 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment