Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Update src/core/Vector3.js #2504

Closed
wants to merge 2 commits into
from

Conversation

3 participants
Contributor

Wilt commented Oct 12, 2012

Hello THREE community!
Would be great if a function to get the angle to another vector could be implemented in this Vector3 class.
Hope you guys like the idea.

Wilt added some commits Oct 12, 2012

Update src/core/Vector3.js
Would be great if the function to get angle to anonther vector could be implemented in this Vector3 class.
Hope you guys like the idea.
Contributor

Wilt commented Oct 13, 2012

Tapio, thanks for your very constructive comments.
I added the changes. Looks indeed much better now.

Contributor

tapio commented Oct 13, 2012

One more nitpick (too late now, but for future): "Update that file" is not really a good summary of the changes - imagine having a lot of those in the git log - you have absolutely no idea what has been done if you don't dive into the diffs. Examples of more descriptive commit summaries for these commits would have been: "Add function to calculate angle between two Vector3s" and for the second one "Tweaked Vector3.angleTo() style and performance", or perhaps "Simplified Vector3.angleTo()" :)

Owner

mrdoob commented Oct 15, 2012

Looks good guys!
@tapio thanks for the guidance :)

Owner

mrdoob commented Oct 15, 2012

@Wilt One last thing. Try to target the dev branch next time.

Owner

mrdoob commented Oct 15, 2012

Merged in the dev branch. Thanks!

@mrdoob mrdoob closed this Oct 15, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment