PassNode: Ensure clear of internal render target. #31993
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #31966.
Description
#31966 exposed an issue in
PassNode: IfautoClearis set tofalse, the internal render target is never cleared which yields to different bugs in the backends. WebGL produces a persistent after image effect whereas WebGPU produces just a black texture.The PR introduces the same behavior like in other FX passes by resetting the flag to its default value. We are not using
RendererUtils.resetRendererState()though since most renderer settings should applied toPassNodeas well.If we don't want to force a clear, we would have to expose a
PassNode.clear()method which I'm not sure is necessary at the moment.