Skip to content

Conversation

@querielo
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings October 19, 2025 15:21
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds the aoNode property to the NodeMaterial clone method and fixes a documentation error. The change ensures that ambient occlusion nodes are properly copied when cloning NodeMaterial instances.

  • Added aoNode property copying in the clone method
  • Fixed documentation comment that incorrectly referenced "normals" instead of "opacity"

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 348.94
84.6
348.94
84.6
+0 B
+0 B
WebGPU 603.53
169.27
603.55
169.27
+21 B
+4 B
WebGPU Nodes 602.13
169.03
602.15
169.04
+21 B
+4 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 480.6
119.35
480.6
119.35
+0 B
+0 B
WebGPU 672.94
184.7
672.96
184.71
+21 B
+5 B
WebGPU Nodes 615.45
168.09
615.47
168.09
+21 B
+4 B

@Mugen87 Mugen87 changed the title Add aoNode to NodeMaterial clone NodeMaterial: Honor aoNode in clone(). Oct 19, 2025
@Mugen87 Mugen87 added this to the r181 milestone Oct 19, 2025
@Mugen87 Mugen87 merged commit cbe52bc into mrdoob:dev Oct 19, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants