Partial revert of some WebVR 1.1 changes #9709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They didn't produce correct eye translations in all cases (specifically standing scenes.) This reverted version may not be 100% accurate on future hardware (if the eyes have a rotation component, for example) but it's correct on all current WebVR implementations. That's better than blatantly wrong in some cases. Use of the WebVR-provided projection matricies has been left in, since that was working correctly.
|
Thanks, I just updated the project with this provisional version and works great with 1.1. |
|
Thanks! |
|
Should I cherry-pick this to |
|
Probably be a good idea. Without it anyone with the latest Chrome build will get weird stereo convergence issues on the Vive samples when looking up or down by a significant amount. |
mrdoob
pushed a commit
that referenced
this pull request
Sep 20, 2016
They didn't produce correct eye translations in all cases (specifically standing scenes.) This reverted version may not be 100% accurate on future hardware (if the eyes have a rotation component, for example) but it's correct on all current WebVR implementations. That's better than blatantly wrong in some cases. Use of the WebVR-provided projection matricies has been left in, since that was working correctly.
|
Done! |
aardgoose
pushed a commit
to aardgoose/three.js
that referenced
this pull request
Oct 7, 2016
They didn't produce correct eye translations in all cases (specifically standing scenes.) This reverted version may not be 100% accurate on future hardware (if the eyes have a rotation component, for example) but it's correct on all current WebVR implementations. That's better than blatantly wrong in some cases. Use of the WebVR-provided projection matricies has been left in, since that was working correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They didn't produce correct eye translations in all cases (specifically
standing scenes.) This reverted version may not be 100% accurate on
future hardware (if the eyes have a rotation component, for example) but
it's correct on all current WebVR implementations. That's better than
blatantly wrong in some cases.
Use of the WebVR-provided projection matricies has been left in, since
that was working correctly.
Addresses #9708 for the time being. I'll keep looking into it.