Add setOverrideMimeType() to XHRLoader #9959

Merged
merged 3 commits into from Nov 2, 2016

Projects

None yet

2 participants

@takahirox
Contributor

This PR adds setOverrideMimeType() to XHRLoader.
Users can specify charcode of downloaded file with it.

I need this ability because
VPD file which includes MMD pose data is generally shift_jis.
To load the file correctly
I need to set request.overrideMimeType( 'text/plain; charset=shift_jis' );

@mrdoob
Owner
mrdoob commented Oct 28, 2016 edited

Looks good! How about calling it setMimeType() instead though?

@takahirox
Contributor

Agreed! I'll update soon

@mrdoob
Owner
mrdoob commented Oct 28, 2016

Ops, you'll have to pull from dev first. I've just renamed XHRLoader to FileLoader... 😇

@takahirox
Contributor

I've done!

@mrdoob mrdoob merged commit 0d47a62 into mrdoob:dev Nov 2, 2016
@mrdoob
Owner
mrdoob commented Nov 2, 2016

Thanks!

@takahirox takahirox deleted the takahirox:XHRLoaderOverrideMimeType branch Nov 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment