Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support graphviz/dot files #27

Merged
merged 3 commits into from Feb 15, 2019

Conversation

Projects
None yet
2 participants
@jonathansty
Copy link
Collaborator

jonathansty commented Feb 14, 2019

As discussed in #26 , this PR adds the ability to render out a flowgraph to a file.

When --unpretty=flowgraph=[symbol] is used we pass the unformatted output through dot. For this to work dot has to be in the PATH though.

Show resolved Hide resolved src/lib.rs Outdated
Show resolved Hide resolved src/lib.rs Outdated
Show resolved Hide resolved src/lib.rs Outdated
Show resolved Hide resolved src/lib.rs Outdated
@mre

This comment has been minimized.

Copy link
Owner

mre commented Feb 14, 2019

Thanks for tackling this! I haven't tried it yet, but it looks promising and I'm really looking forward to having this merged. Added a few comments. 😃

jonathansty added some commits Feb 14, 2019

@jonathansty

This comment has been minimized.

Copy link
Collaborator Author

jonathansty commented Feb 14, 2019

I've applied the feedback. Let me know if there's any more issues.

@mre

This comment has been minimized.

Copy link
Owner

mre commented Feb 15, 2019

Tested and works beautifully! Thanks for that. If you want, you can add a section about it to the README.md and maybe announce it on Twitter or so. Otherwise, I can do it. 🙂

@mre mre merged commit 412e5be into mre:master Feb 15, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jonathansty

This comment has been minimized.

Copy link
Collaborator Author

jonathansty commented Feb 15, 2019

@mre I won't be able to do that until tomorrow so feel free to go ahead and do it if you've got some free time.

@mre

This comment has been minimized.

Copy link
Owner

mre commented Feb 15, 2019

Sure! I've added some notes to the README.md and released 0.9.0. We also have a changelog now. Will do the announcement on Twitter now and mention you.

@mre

This comment has been minimized.

Copy link
Owner

mre commented Feb 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.