New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the folder structure and build #13

Merged
merged 1 commit into from Oct 11, 2018

Conversation

Projects
None yet
2 participants
@fabiorphp
Collaborator

fabiorphp commented Oct 8, 2018

For now the folder structure following the Golang projects specs.
Changed the makefile build to save the output in build folder.
Updated the gorelease file for building the project into build folder.

Relates: #10

@mre

This comment has been minimized.

Show comment
Hide comment
@mre

mre Oct 9, 2018

Owner

Merged another PR. Could you reintegrate the master @fabiorphp?

Owner

mre commented Oct 9, 2018

Merged another PR. Could you reintegrate the master @fabiorphp?

@mre

This comment has been minimized.

Show comment
Hide comment
@mre

mre Oct 9, 2018

Owner

Uhm, hate to say it but I did it again. My fault. 😅 Could you reintegrate master a final time. I promise your PR will be merged next. Alternatively, I could also merge directly from CLI if that's more convenient for you. Changes look good.

Owner

mre commented Oct 9, 2018

Uhm, hate to say it but I did it again. My fault. 😅 Could you reintegrate master a final time. I promise your PR will be merged next. Alternatively, I could also merge directly from CLI if that's more convenient for you. Changes look good.

Change the folder structure and build
For now the folder structure following the Golang projects specs.
Changed the makefile build to save the output in build folder.
Updated the gorelease file for building the project into build folder.
@mre

This comment has been minimized.

Show comment
Hide comment
@mre

mre Oct 11, 2018

Owner

Thanks @fabiorphp. 🎸

Owner

mre commented Oct 11, 2018

Thanks @fabiorphp. 🎸

@mre mre merged commit cc09409 into mre:master Oct 11, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@fabiorphp fabiorphp deleted the fabiorphp:feature/folder-structure branch Oct 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment