New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added alternative symfony/console versions (~3.0 and ~4.0). #5

Merged
merged 2 commits into from Nov 30, 2018

Conversation

Projects
None yet
2 participants
@corpsee
Contributor

corpsee commented Nov 30, 2018

I added alternative symfony/console versions (~3.0 and ~4.0).

I develop project PHP Censor which use your library and it use symfony/console v3.4.*. Could you release new version (I guess: 1.0.1) of library after the pull request merge please?

@@ -14,7 +14,7 @@
"require": {
"php": ">=5.3.3",
"guzzle/guzzle": "~3.7",
"symfony/console": "~2.5"
"symfony/console": "~2.5|~3.0|~4.0"

This comment has been minimized.

@mremi

mremi Nov 30, 2018

Owner

It could be great to upgrade the whole stack, I mean support "php": "^7.1" and "symfony/console": "^3.0 || ^4.0", WDYT?

This comment has been minimized.

@corpsee

corpsee Nov 30, 2018

Contributor

@mremi I need PHP version 5.6. Could you release v1.0.1 without update PHP version? And I would create new pull request with all stack update for another version 2.0.0?

This comment has been minimized.

@mremi

mremi Nov 30, 2018

Owner

Ok for me, can you please fix the CI failure by removing support for PHP < 5.6? Just remove the lines in .travis.yml and update the composer.json with ^5.6.

This comment has been minimized.

@corpsee

corpsee Nov 30, 2018

Contributor

Done. I guess now version should be 2.0.0 and version for PHP ^7.1 should be 3.0.0 😄

This comment has been minimized.

@mremi

mremi Nov 30, 2018

Owner

You could require "php": "^5.6 || ^7.1" and remove 7.0 in travis, not supported anymore soon

This comment has been minimized.

@corpsee

corpsee Nov 30, 2018

Contributor

@mremi Done.

@mremi mremi referenced this pull request Nov 30, 2018

Merged

Fixed Guzzle package name. #6

@corpsee corpsee force-pushed the corpsee:symfony-console branch from a4acf83 to 410cb28 Nov 30, 2018

@mremi

👍Last point, could you please create CHANGELOG.md?

@corpsee corpsee force-pushed the corpsee:symfony-console branch from 410cb28 to 7c985e9 Nov 30, 2018

@corpsee

This comment has been minimized.

Contributor

corpsee commented Nov 30, 2018

Done.

@mremi mremi merged commit c678a5f into mremi:master Nov 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mremi

This comment has been minimized.

Owner

mremi commented Nov 30, 2018

Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment