Michael Rennie mrennie

Organizations

@firebug
mrennie commented on issue marijnh/tern#526
@mrennie

In case you change your mind and do decide to provide a CLA, I have one ready to go here: https://github.com/mrennie/tern/blob/issue526/CONTRIBUTIN…

mrennie created branch issue526 at mrennie/tern
mrennie opened issue marijnh/tern#526
@mrennie
Consider adding a contributing.md file
mrennie commented on issue marijnh/tern#360
@mrennie

For what its worth, that is how we use Tern + ESLint, etc in Orion: we regex out the script blocks into a 'file' and run that through the tools: See

mrennie commented on issue CSSLint/csslint#584
@mrennie

Perhaps it might be worthwhile to also add it to the contributing wiki (or only add it to the wiki): https://github.com/CSSLint/csslint/wiki/Contri…

mrennie opened pull request CSSLint/csslint#585
@mrennie
Adds a CLA to contributing.md
1 commit with 12 additions and 0 deletions
mrennie created branch issue584 at mrennie/csslint
@mrennie
Add Contributor License Agreement (and contributing.md)
@mrennie
Provide a Contributor License Agreement
mrennie commented on pull request jquery/esprima#262
@mrennie

Yes, I can update the fix to the latest Esprima.

mrennie commented on issue jquery/esprima#1071
@mrennie

The problems still exist using the very latest from master.

mrennie commented on issue jquery/esprima#1071
@mrennie

Here is another interesting case from some of our test failures: switch(a) { case 1: switch(b) { case 1: foo; //$FALLTHROUGH$ case 2: foo; } } The …

mrennie commented on issue jquery/esprima#1071
@mrennie

For what its worth, I originally found the problem while working on Orion bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=460468 My branch has t…

mrennie commented on issue jquery/esprima#1071
@mrennie

/**/ function a() {function o() {}} Run on http://esprima.org/demo/parse.html produces: { "range": [ 5, 35 ], "type": "Program", "body": [ { "range":…

mrennie commented on issue jquery/esprima#1071
@mrennie

Here is another simple example: /**/function f() {var a;} Looks like the attaching code is attaching the comments to the first 'finished' node rath…

@mrennie
@mrennie
Comments are attached to the wrong node with starting function expression
mrennie commented on issue mrennie/crossfire#29
@mrennie

No work is on-going or planned for this project. The last time it was tested was with Firebug 1.7 (and the Firefox versions that it ran on), so th…

mrennie commented on issue marijnh/tern#489
@mrennie

The mentioned link ( https://bugs.eclipse.org/bugs/show_bug.cgi?id=432940#c17) pretty much sums up where the work is at right now - I have been foc…

@mrennie
StringReader fails to normalize Windows line endings
mrennie commented on issue marijnh/acorn#199
@mrennie

I would be more than happy to work on ensuring parse_dammit can parse valid JavaScript source it you would be interested in such a contribution.

mrennie commented on issue marijnh/acorn#199
@mrennie

This is kind of by design: Thanks for the pointer, but this feels like a serious flaw. I assumed (obviously incorrectly) that both parsers could p…

mrennie opened issue marijnh/acorn#199
@mrennie
parse_dammit fails to parse ArrayExpression on multiple lines
mrennie opened issue marijnh/acorn#197
@mrennie
Incomplete block comment truncates token list