Permalink
Browse files

Housekeeping in errors scripts

Enable warnings - remove Bug 2505 FIXME messages
Correct FSF address in License statement
To aid code analysis tools:
Call new unambiguously with arrow syntax
use noninterpolating quotes on noninterpolating strings

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
  • Loading branch information...
1 parent b9ed528 commit 126dfd54ec20c7153f2ee367d172a567c5849f79 @colinsc colinsc committed with ranginui May 12, 2010
Showing with 36 additions and 37 deletions.
  1. +6 −6 errors/400.pl
  2. +6 −7 errors/401.pl
  3. +6 −6 errors/402.pl
  4. +6 −6 errors/403.pl
  5. +6 −6 errors/404.pl
  6. +6 −6 errors/500.pl
View
@@ -12,24 +12,24 @@
# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License along with
-# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
-# Suite 330, Boston, MA 02111-1307 USA
+# Koha; if not, write to the Free Software Foundation, Inc.,
+# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
use strict;
-#use warnings; FIXME - Bug 2505
+use warnings;
use CGI;
use C4::Auth;
use C4::Output;
use C4::Context;
-my $query = new CGI;
+my $query = CGI->new;
my $admin = C4::Context->preference('KohaAdminEmailAddress');
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
{
- template_name => "errors/400.tmpl",
+ template_name => 'errors/400.tmpl',
query => $query,
- type => "intranet",
+ type => 'intranet',
authnotrequired => 1,
debug => 1,
}
View
@@ -12,24 +12,23 @@
# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License along with
-# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
-# Suite 330, Boston, MA 02111-1307 USA
-
+# Koha; if not, write to the Free Software Foundation, Inc.,
+# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
use strict;
-#use warnings; FIXME - Bug 2505
+use warnings;
use CGI;
use C4::Auth;
use C4::Output;
use C4::Context;
-my $query = new CGI;
+my $query = CGI->new;
my $admin = C4::Context->preference('KohaAdminEmailAddress');
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
{
- template_name => "errors/401.tmpl",
+ template_name => 'errors/401.tmpl',
query => $query,
- type => "intranet",
+ type => 'intranet',
authnotrequired => 1,
debug => 1,
}
View
@@ -12,24 +12,24 @@
# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License along with
-# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
-# Suite 330, Boston, MA 02111-1307 USA
+# Koha; if not, write to the Free Software Foundation, Inc.,
+# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
use strict;
-#use warnings; FIXME - Bug 2505
+use warnings;
use CGI;
use C4::Auth;
use C4::Output;
use C4::Context;
-my $query = new CGI;
+my $query = CGI->new;
my $admin = C4::Context->preference('KohaAdminEmailAddress');
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
{
- template_name => "errors/402.tmpl",
+ template_name => 'errors/402.tmpl',
query => $query,
- type => "intranet",
+ type => 'intranet',
authnotrequired => 1,
debug => 1,
}
View
@@ -12,24 +12,24 @@
# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License along with
-# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
-# Suite 330, Boston, MA 02111-1307 USA
+# Koha; if not, write to the Free Software Foundation, Inc.,
+# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
use strict;
-#use warnings; FIXME - Bug 2505
+use warnings;
use CGI;
use C4::Auth;
use C4::Output;
use C4::Context;
-my $query = new CGI;
+my $query = CGI->new;
my $admin = C4::Context->preference('KohaAdminEmailAddress');
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
{
- template_name => "errors/403.tmpl",
+ template_name => 'errors/403.tmpl',
query => $query,
- type => "intranet",
+ type => 'intranet',
authnotrequired => 1,
debug => 1,
}
View
@@ -12,24 +12,24 @@
# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License along with
-# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
-# Suite 330, Boston, MA 02111-1307 USA
+# Koha; if not, write to the Free Software Foundation, Inc.,
+# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
use strict;
-#use warnings; FIXME - Bug 2505
+use warnings;
use CGI;
use C4::Auth;
use C4::Output;
use C4::Context;
-my $query = new CGI;
+my $query = CGI->new;
my $admin = C4::Context->preference('KohaAdminEmailAddress');
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
{
- template_name => "errors/404.tmpl",
+ template_name => 'errors/404.tmpl',
query => $query,
- type => "intranet",
+ type => 'intranet',
authnotrequired => 1,
debug => 1,
}
View
@@ -12,24 +12,24 @@
# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License along with
-# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
-# Suite 330, Boston, MA 02111-1307 USA
+# Koha; if not, write to the Free Software Foundation, Inc.,
+# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
use strict;
-#use warnings; FIXME - Bug 2505
+use warnings;
use CGI;
use C4::Auth;
use C4::Output;
use C4::Context;
-my $query = new CGI;
+my $query = CGI->new;
my $admin = C4::Context->preference('KohaAdminEmailAddress');
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
{
- template_name => "errors/500.tmpl",
+ template_name => 'errors/500.tmpl',
query => $query,
- type => "intranet",
+ type => 'intranet',
authnotrequired => 1,
debug => 1,
}

0 comments on commit 126dfd5

Please sign in to comment.