Permalink
Browse files

Bug 9535 - Patron card creator "Remove duplicates" function doesn't work

This bug was due to a difference in field names used in the item data
for items versus patrons. This patch adds a ternary to discern between
the two.

To test:

Before applying patch:

1. Create a batch of patroncards with one duplicate.
2. Run the de-duplication on the batch.
3. Note that all patrons beyond the first in the batch are now
   deleted.

After applying patch:
4. Repeat steps 1-2.
5. Note that only the duplicate patron is removed.

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Tested successfully with both patron card batches and label batches.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Add indentation for readability
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
  • Loading branch information...
1 parent 9d784c5 commit c70c7185dc6b28151fa9a28e4b2aa13a52d9fc23 Chris Nighswonger committed with jcamins Apr 2, 2013
Showing with 5 additions and 1 deletion.
  1. +5 −1 C4/Creators/Batch.pm
@@ -199,7 +199,11 @@ sub remove_duplicates {
my %seen=();
my $query = "DELETE FROM creator_batches WHERE label_id = ?;"; # ORDER BY timestamp ASC LIMIT ?;";
my $sth = C4::Context->dbh->prepare($query);
- my @duplicate_items = grep{$seen{$_->{'item_number'}}++} @{$self->{'items'}};
+ my @duplicate_items = grep{
+ $_->{'item_number'}
+ ? $seen{$_->{'item_number'}}++
+ : $seen{$_->{'borrower_number'}}++
+ } @{$self->{'items'}};
foreach my $item (@duplicate_items) {
$sth->execute($item->{'label_id'});
if ($sth->err) {

0 comments on commit c70c718

Please sign in to comment.