Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Apr 30, 2015
  1. @oleonard @tomascohen

    Bug 9528: Add delivery branch to the place hold display

    oleonard authored tomascohen committed
    When viewing the list of a patron's holds from the circulation or patron
    detail page the pickup library is not listed. This patch adds a column
    to the table of holds which shows the pickup branch.
    
    This patch also removes some unnecessary markup from the generation of
    the table and corrects an instance where the term "reserve" was used
    instead of "hold."
    
    This patch also modifies the language describing an item which is marked
    waiting at the current library: "Item is waiting here" instead of "Item
    waiting."
    
    To test, add several holds to a patron's account with various pickup
    locations.
    
    - Confirm that those pickup locations are correctly displayed
      under the Holds tab in Circulation.
    
    - Check in and confirm a hold which is to be picked up at the current
      branch. Confirm that the revised language appears.
    
    - Confirm that table sorting works correctly.
    
    Signed-off-by: Nick <Nick@quechelibrary.org>
    
    Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
  2. @kylemhall @tomascohen

    Bug 13442: Facet links broken when collection code limit is used

    kylemhall authored tomascohen committed
    Any search limits including a ccode will break the search facts.
    
    Test Plan:
    1) Run an advanced search using a ccode limit
    2) Try using any of the facet links of the left
    3) Note they are broken
    4) Apply this patch
    5) Refresh the results
    6) Note the facet links are no longer broken
    
    Note: I have not been able to reproduce this issue on my own test
    system, but have noted the problem on at least a dozen Koha servers.
    
    I could not reproduce the bug either, but I saw it on the Bywater Demo (comment #1).
    Applied patch and tested facets, no problems found, signing off
    Signed-off-by: Marc Véron <veron@veron.ch>
    
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
    Can not reproduce the problem, but I can also not find a regression.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
  3. @joubu @tomascohen

    Bug 6059: Don't permit to change the quantity when items are created …

    joubu authored tomascohen committed
    …on ordering
    
    If items are created on ordering, the quantity for uncertain prices
    should not be editable.
    
    Test plan:
    0/ Set AcqCreateItem to "on ordering"
    1/ Create a basket and add an order with 1+ items
    2/ Mark it as uncertain prices
    3/ Go on the uncertain prices page for this vendor
    (acqui/uncertainprice.pl?booksellerid=X)
    4/ Confirm you are not allowed to update the quantity
    5/ Change the price and save
    6/ Confirm the quantity is still correct
    
    Set the pref to another value and confirm the behavior has not changed.
    
    NOTE: Tested with 'on placing order' and 'on receiving order'.
    
    Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
  4. @tomascohen

    Bug 8007: (followup) double quotes...

    tomascohen authored
    Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
  5. @kylemhall @tomascohen

    Bug 7843: (QA followup) Make news selection persistant

    kylemhall authored tomascohen committed
    This patch makes the following changes:
    1) If there is no logged in patron, the RSS link states it is for
       system-wide news.
    2) If a patron is logged in, the RSS link states it is for system-wide
       news *and* news for the patron's home library.
    3) The patron's home branch code is embedded in the RSS feed url so
       he or she no longer needs to be logged in for us to know what branch's
       news to pull.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
  6. @bgkriegel @tomascohen

    Bug 7843: Followup - fix broken url

    bgkriegel authored tomascohen committed
    This patch fixes an invalid URL when clicking
    on RSS feed.
    
    To test:
    1) Using Nicole words :)
    If you visit : http://mykoha/cgi-bin/koha/opac-main.pl
    then the RSS feed works.
    If you're on http://mykoha and you click the rss icon you
    get : http://mykoha/opac-news-rss.pl which is a 404 page.
    
    2) Apply the patch
    
    3) Repeat 1, error is now fixed
    
    Signed-off-by: Pierre <tredok.pierre@gmail.com>
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
  7. @nengard @tomascohen

    Bug 7843: (follow up) Improve RSS feed language

    nengard authored tomascohen committed
    The RSS button used to read ' RSS for the librarys general newsfeed.'
    This included one grammatical error and I think included more words
    than most average people would read.  This patch simplifies it to say
    'RSS for Library News.'
    
    To test:
    * Apply all patches
    * Review RSS feed button's text on main page under news
    
    http://bugs.koha-community.org/show_bug.cgi?id=7843
    
    Signed-off-by: Pierre <tredok.pierre@gmail.com>
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
  8. @joubu @tomascohen

    Bug 7843: (qa-followup) Create an RSS feed for news in Opac

    joubu authored tomascohen committed
    1/ use strict and warnings are useless, Modern::Perl is used
    2/ Prefer to use the interface and theme TT var instead of the hard
    coded path
    
    Signed-off-by: Pierre <tredok.pierre@gmail.com>
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
  9. @joubu @tomascohen

    Bug 7843: Remove the useless use of casAuthentication

    joubu authored tomascohen committed
    Certainly a c/p error from opac-main.pl
    
    Signed-off-by: Pierre <tredok.pierre@gmail.com>
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
  10. @regionbibliotekhalland @tomascohen

    Bug 7843: Create an RSS feed for news in Opac

    regionbibliotekhalland authored tomascohen committed
    Test plan:
    * Install the patch
    * Make shure there is news in the Opac
    * Go to the Opac (opac-main.pl)
    * Make shure you see an RSS icon below the news and a short text.
    * Click the RSS icon and verify that you get an RSS feed that validates.
    
    Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
    
    I took the liberty of fixing the copyright statement when signing it off
    
    Signed-off-by: Pierre <tredok.pierre@gmail.com>
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
  11. @joubu @tomascohen

    Bug 11814: Fix existing tests

    joubu authored tomascohen committed
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
  12. @joubu @tomascohen

    Bug 11814: Fix sql parameters order

    joubu authored tomascohen committed
    Oops, bad paramaters passed on executing the sql query produced
    unexpected behaviors.
    
    Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
  13. @joubu @tomascohen

    Bug 11814: (follow-up) Use constants to describe statuses

    joubu authored tomascohen committed
    This patch deals with all hard-coded status codes in the C4::Serials
    module.
    
    Test plan:
    Test a complete workflow in the serial module (create, order, receive,
    generate next) trying to use all statuses.
    
    Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
  14. @kylemhall @tomascohen

    Bug 11814: Use constants to describe statuses

    kylemhall authored tomascohen committed
    Make the code a bit more understandable by using constants to define
    the status values and reference those. Adds self-documentation.
    
    Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
  15. @joubu @tomascohen

    Bug 1487: Store the "display only used tags/subf" value in a cookie

    joubu authored tomascohen committed
    On the marc framework page, the checkbox to display only used
    tags/subfields is always unchecked.
    It should be stored into a cookie to always display the same view.
    
    Test plan:
    1/ Go on the marc framework page
    2/ Check the checkbox
    3/ Go somewhere else on the staff interface
    4/ Back to the marc framework page, the checkbox should be checked
    
    Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Works as advertised, getting datatables error when using feature
    but the error exists pre-patch
    Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
  16. @tomascohen

    Bug 8007: (followup) manually add the <body> tag

    tomascohen authored
    Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
  17. @tomascohen

    Bug 8007: (QA followup) <body> was missing id and class

    tomascohen authored
    Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
  18. @tomascohen

    Bug 8007: (QA followup) fix charset collate

    tomascohen authored
    This bug was started before the changes on default collation. This
    patch fixes that.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
  19. @tomascohen

    Bug 8007: DBRev 3.19.00.035

    tomascohen authored
    Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
  20. @joubu @tomascohen

    Bug 8007: (QA followup) Add error handling when generating the pdf

    joubu authored tomascohen committed
    If error occurs when generating the pdf, it would be better to get an
    encapsulated error instead of the "software error" message in the pdf
    file.
    To test this patch I added this change:
    
    b/Koha/Borrower/Discharge.pm
    -115,6 +115,7 @@ sub generate_as_pdf {
         say $html_fh $html_content;
         close $html_fh;
         my $pdf = PDF::FromHTML->new( encoding => 'utf-8' );
    +    $html_path .= "poeut";
         $pdf->load_file( $html_path );
         $pdf->convert;
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
  21. @tomascohen

    Bug 8007: (QA followup) wording issue on sysprefs

    tomascohen authored
    Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
  22. @tomascohen

    Bug 8007: (QA followup) fix kohastructure to follow guidelines

    tomascohen authored
    Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
  23. @tomascohen

    Bug 8007: (RM followup) fix DBIx schema checksum

    tomascohen authored
    Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
  24. @joubu @tomascohen

    Bug 8007: Compatibility with bug 11944

    joubu authored tomascohen committed
    This patch should be applied to work with bug 11944.
    If you don't have 11944 yet, just don't apply this patch.
    
    Note that the line
      binmode(STDOUT);
    in pl files is mandatory.
    
    It comes from bug 11944 that adds the line
      binmode( STDOUT, ":utf8" );
    in C4::Templates::gettemplate.
    
    Signed-off-by: Lucie <lucie.rousseaux@dracenie.com>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
  25. @joubu @tomascohen

    Bug 8007: Replace HTML::HTMLDoc with PDF::FromHTML

    joubu authored tomascohen committed
    Signed-off-by: Lucie <lucie.rousseaux@dracenie.com>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
  26. @tomascohen

    Bug 8007: Discharge - Adding Perl dependencie

    Yohann Dufour authored tomascohen committed
    HTML::HTMLDoc is required in order to generate the discharges in PDF format.
    
    Signed-off-by: Lucie <lucie.rousseaux@dracenie.com>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
  27. @tomascohen

    Bug 8007: Discharge - Add unit tests

    Yohann Dufour authored tomascohen committed
    Signed-off-by: Lucie <lucie.rousseaux@dracenie.com>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
  28. @tomascohen

    Bug 8007: Discharge management

    Yohann Dufour authored tomascohen committed
    This patch is the main patch. It adds new package and files for the new
    pages (opac-discharge, members/discharge and members/discharges).
    
    At the intranet, it is now possible to generate a discharge for a patron.
    At the opac, a patron can request a discharge and a discharge if it has
    been validated by a librarian.
    
    Requirements:
        The perl module PDF::FromHTML
    
    New sysprefs:
     - useDischarge: Allows librarians to discharge borrowers and borrowers
       to request a discharge
    
    New letter with a letter_code DISCHARGE.
    
    Test plan:
    - Switch on the syspref useDischarge.
    - Verify a new tab appears in the patron page (intranet and opac).
    - Verify the discharge cannot be generated if the patron has issues.
    - Verify the patron can request a discharge from it's opac area.
    - The request appears on the main page (intranet).
    - Generate the discharge from the intranet.
    - Try to download it (from the opac and the intranet).
    
    Signed-off-by: Lucie <lucie.rousseaux@dracenie.com>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
  29. @tomascohen

    Bug 8007: Discharge - Glue

    Yohann Dufour authored tomascohen committed
    This patch adds:
    - links to the new pages.
    - syspref description
    - links on the main page (intranet)
    - the DISCHARGE type for debarment
    
    Signed-off-by: Lucie <lucie.rousseaux@dracenie.com>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
  30. @tomascohen

    Bug 8007: Discharge - DBIx changes

    Yohann Dufour authored tomascohen committed
    Signed-off-by: Lucie <lucie.rousseaux@dracenie.com>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
  31. @tomascohen

    Bug 8007: Discharge - DB changes

    Yohann Dufour authored tomascohen committed
    This patch adds:
    - syspref useDischarge
    - the new table discharges
    - the discharge notice
    
    Signed-off-by: Lucie <lucie.rousseaux@dracenie.com>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
  32. @tomascohen

    Bug 7939: (QA followup) make the koha-translate script test the new f…

    tomascohen authored
    …ilenames
    
    The debian/scripts/koha-translate script was still testing for the old naming
    schema files. I also made sure all files are tested, to warn the user if
    any of them is absent.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
  33. @bgkriegel @tomascohen

    Bug 7939: (followup) Update translation files

    bgkriegel authored tomascohen committed
    Create/rename/update/fix translation files
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
  34. @bgkriegel @tomascohen

    Bug 7939: Separate po files for different MARC dialects

    bgkriegel authored tomascohen committed
    This patch implements separate PO files for
    different MARC dialects.
    
    It depends on correct filenames, i.e. it will build PO
    files using files with/without "unimarc|normarc|marc21"
    on their names.
    
    Changes:
    A) LangInstaller.pm
    Added definitions to create or update xx-YY-{MARCFLAVOR}.po,
    minor change to create and install procedure, and modification
    of install procedure to handle multiple target dirs.
    Updated documentation.
    
    B) Standarization of filenames
    STAFF po file is now xx-YY-staff-prog.po
    MARC dialects po files are xx-YY-marc-{MARCFLAVOUR}.po
    
    To test:
    1) Update po files for your preferred language, ej. nn-NO
    cd misc/translator
    perl translate update nn-NO
    
    2) Do some copying/renaming
    cp po/nn-NO-i-staff-t-prog-v-3006000.po po/nn-NO-marc-UNIMARC.po
    cp po/nn-NO-i-staff-t-prog-v-3006000.po po/nn-NO-marc-NORMARC.po
    cp po/nn-NO-i-staff-t-prog-v-3006000.po po/nn-NO-marc-MARC21.po
    mv po/nn-NO-i-staff-t-prog-v-3006000.po po/nn-NO-staff-prog.po
    
    (most MARC dialect strings are on staff, so we use that as basis)
    
    3) Apply the patch
    
    4) Update again to fix translation files, verbose
    perl translate update nn-NO -v
    
    5) Install language, verbose, verify translations
    perl translate install nn-NO -v
    
    6) Create translation files
    rm po/nn-NO*
    perl translate create nn-NO
    
    we must have this list:
    po/nn-NO-marc-MARC21.po
    po/nn-NO-marc-NORMARC.po
    po/nn-NO-marc-UNIMARC.po
    po/nn-NO-opac-bootstrap.po
    po/nn-NO-pref.po
    po/nn-NO-staff-help.po
    po/nn-NO-staff-prog.po
    
    Additional tests:
    7) Number of msgids
    7.a) Before patch and after upgrade, extract and count msgids
    for i in $(ls po/nn-NO-*po); \
    do msginit -i $i -o nn-old.po --no-translator --no-wrap --locale=nn_NO; \
    egrep ^msgid nn-old.po >> old; \
    done
    sort old | uniq | tee s-old | wc -l > n-old
    s-old: have all msgids
    n-old: number of msgids
    
    7.b) After patch and after creation of new files
    Repeat procedure, diferent files (s-new, n-new)
    
    7.c) Compare (diff s-old snew), they are the same
    (save for a strange UNIMARC char in my case, but
    it's present on corresponding PO file)
    
    8) Installed dirs/files
    8.a) List of EN dirs/files
    cd koha-tmpl
    find | egrep "/en/" > en
    
    8.b) List of nn-NO dirs/files. After patch and language install
    cd koha-tmpl
    find | egrep "/nn-NO/" | sed 's|/nn-NO/|/en/|' > nn
    
    8.c) Compare (diff en nn), they are the same
    
    Signed-off-by: Magnus Enger <magnus@enger.priv.no>
    Followed the steps outlined by Bernardo, and everything works as
    expected. I think the most important points are that "perl translate
    create nn-NO" produces the right files, and translating anything in
    them, then doing "translate install" makes the translations show
    up in the interface. The numbers msgids in the nn-NO correspond
    well wit the number of msgids in other sets of .po files.
    
    I bet y'all will be happy when you don't have to see the stupid
    Norwegian strings when you translate! ;-)
    
    Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Commits on Apr 29, 2015
  1. @mderooy @tomascohen

    Bug 13893: [QA Follow-up] Move print statement, sort files in loop

    mderooy authored tomascohen committed
    Just moving the print statement for DEV updates to show them too for
    the new perl format.
    In the loop opendir..readdir is used; this might not be always in the
    expected order. I added a sort to force the order.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
    Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Something went wrong with that request. Please try again.