You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
there is only one decrement statement because the early-exit for creative (and the call to burningTick) is before the decrement.
Iʼm not sure if the Forge solution would work here; there are some differences in burningTick that mean it might run into issues based on whether itʼs before or after the decrement in the case where we are now out of fuel. But at the very least the first conditional should be removed.
Additional context
Mod version: 1.2.3
Fabric version: 0.15.7
Create version: 0.5.1f build 1335
The text was updated successfully, but these errors were encountered:
Fixesmrh0#782. This is not quite equivalent to the Forge implementation,
because I didn't want to worry about that implementing off-by-one errors
(see the referenced issue), but does work with brief testing.
I changed the order to make liquid blaze burners refill instantly (see also #726). I'd maybe do this on forge too because this might happen again next time we merge forge into fabric.
dhouck
added a commit
to dhouck/barry-minecraft-server-modpack
that referenced
this issue
Apr 26, 2024
Describe the bug
Liquid-fuel blaze burners decrement their time remaining twice per tick, so use fuel at twice the expected rate.
To Reproduce
Alternate steps 4 and 5: use Carpet mod to tick step and see that the burn time decreases by two each tick.
If you look at
createaddition/src/main/java/com/mrh0/createaddition/blocks/liquid_blaze_burner/LiquidBlazeBurnerBlockEntity.java
Lines 210 to 219 in bf11060
If you look at the equivalent section of the Forge code, you see
createaddition/src/main/java/com/mrh0/createaddition/blocks/liquid_blaze_burner/LiquidBlazeBurnerBlockEntity.java
Lines 200 to 206 in e82c79e
there is only one decrement statement because the early-exit for creative (and the call to
burningTick
) is before the decrement.Iʼm not sure if the Forge solution would work here; there are some differences in
burningTick
that mean it might run into issues based on whether itʼs before or after the decrement in the case where we are now out of fuel. But at the very least the first conditional should be removed.Additional context
The text was updated successfully, but these errors were encountered: