Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct crc-catalog version #61

Merged
merged 1 commit into from May 27, 2021
Merged

Conversation

@striezel
Copy link
Contributor

@striezel striezel commented May 24, 2021

This crate says it works with crc-catalog 1.0.0, but it can't:

   Compiling crc v2.0.0-rc.1 (/opt/crc-rs)
error[E0310]: the parameter type `W` may not live long enough
  --> src/lib.rs:42:20
   |
41 | pub struct Crc<W: Width> {
   |                -- help: consider adding an explicit lifetime bound...: `W: 'static +`
42 |     pub algorithm: &'static Algorithm<W>,
   |                    ^^^^^^^^^^^^^^^^^^^^^ ...so that the reference type `&'static crc_catalog::Algorithm<W>` does not outlive the data it points at

error: aborting due to previous error

For more information about this error, try `rustc --explain E0310`.
error: could not compile `crc`

To learn more, run the command again with --verbose.

This matters when using -Z minimal-versions cargo option.

Cargo.toml Show resolved Hide resolved
@akhilles
Copy link
Collaborator

@akhilles akhilles commented May 24, 2021

@mrhooray I think it's safe to publish 2.0.0. The release candidate hasn't thrown any red flags so far.

@mrhooray mrhooray merged commit 1ba2c74 into mrhooray:master May 27, 2021
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@striezel striezel deleted the striezel-stash:minimal-versions branch May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants