Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not Clicking Confirmation Button #5

Closed
atharakhan opened this issue Jul 8, 2019 · 7 comments
Closed

Not Clicking Confirmation Button #5

atharakhan opened this issue Jul 8, 2019 · 7 comments

Comments

@atharakhan
Copy link

@atharakhan atharakhan commented Jul 8, 2019

Thank you for this wonderful tool. For whatever reason, the script does not seem to click the confirmation button. I looked at the issue opened by MickPBduece but was not able to see a solution in his notes.

@abarberis
Copy link

@abarberis abarberis commented Jul 10, 2019

@atharakhan I submitted a pull request a few days ago to fix it. Use that version for now. Enjoy!

Loading

@zzhang39
Copy link

@zzhang39 zzhang39 commented Jul 15, 2019

update confirmation button to below

confirmationButton: '#yDmH0d > div.llhEMd.iWO5td > div > div.g3VIld.V639qd.bvQPzd.oEOLpc.Up8vH.J9Nfi.A9Uzve.iWO5td > div.XfpsVe.J9fJmf > button.VfPpkd-LgbsSe.VfPpkd-LgbsSe-OWXEXe-k8QpJ.nCP5yc.kHssdc.HvOprf'

Loading

@leewinbush
Copy link

@leewinbush leewinbush commented Jul 19, 2019

Perfect, thanks! Looks like it's working now.

Loading

@rwat1
Copy link

@rwat1 rwat1 commented Aug 19, 2019

@zzhang39 This worked! Thank you very much. Yes, that's working now. Let's see if it works with 66GB of photos. haha.

Edit: It worked pretty quickly, less than 6 hours. I set it to 1000, sometimes 500 milliseconds for increased speed, works well even on slower Wifi.

Loading

@joelrose2
Copy link

@joelrose2 joelrose2 commented Sep 22, 2019

Thanks for this great script. It worked for me (even if slowly), but I had to do two things differently: (1) The script did not click the confirm button (“Move to Trash”) so it initially did nothing - I fixed this by replacing the button’s selector in the code manually, by copying its selector from the page as it appeared in my browser. (2) After pasting the code into console I had to press Enter to get it to start (this is not mentioned in the instructions).

Loading

@GrandNegus68
Copy link

@GrandNegus68 GrandNegus68 commented Sep 25, 2019

In case anyone doesn't see my reply to MickPBduece's Issue :-

It obviously looks like the button class is dynamic (my button class was different to yours and a few others here - not sure if this is client specific or code release specific). So my solution which I hope works as intended (we clearly can't trust the class name being fixed) is to use the nth-child() approach, so it always targets the second button in the button list.. please test this yourself

Change :-
confirmationButton: '#yDmH0d > div.llhEMd.iWO5td > div > div.g3VIld.V639qd.bvQPzd.oEOLpc.Up8vH.J9Nfi.A9Uzve.iWO5td > div.XfpsVe.J9fJmf > button.VfPpkd-LgbsSe.VfPpkd-LgbsSe-OWXEXe-k8QpJ.nCP5yc.DuMIQc.kHssdc.HvOprf'

To :-
confirmationButton: '#yDmH0d > div.llhEMd.iWO5td > div > div.g3VIld.V639qd.bvQPzd.oEOLpc.Up8vH.J9Nfi.A9Uzve.iWO5td > div.XfpsVe.J9fJmf button:nth-child(2)'

Thanks for the script, it is annoying that it can't be done in bulk, but this script will save me a very long time doing it manually

Further to my original reply I have been using this all day and just a gotca, it appears that anything deleted also has to be removed from the drive bin as well as photos bin.. not sure if that's just me, I read something about photos being removed from drive so in my case it might be historical, but currently even after deleting tons of photos my storage useage hasn't gone down much

Also (sorry if I am being annoying) I notice that someone posted an issue about the deleteButton 'targeting' due to language differences, I only had a quick look but I think you could make that bit dynamic too using the method above assuming you can find a parent div that surrounds the necessary button in a consitent manner

Loading

@mrishab
Copy link
Owner

@mrishab mrishab commented Nov 14, 2019

confirmationButton fix is merged: #4

Loading

@mrishab mrishab closed this Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
8 participants