Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

EventMagicMeta will now also discover events defined in base classes of cls. #37

Merged
merged 2 commits into from Mar 27, 2012

Conversation

Projects
None yet
2 participants
Contributor

specialunderwear commented Mar 21, 2012

We've got a lot of events and we want to factor them into separate classes.

Currently that does not work well with EventMagicMeta because it only looks in attrs, not cls for events. The patch makes EventMagicMeta look for all methods defined on cls with an '_event_name' property, which includes the events defined in additional bases of cls.

mrjoes added a commit that referenced this pull request Mar 27, 2012

Merge pull request #37 from specialunderwear/master
EventMagicMeta will now also discover events defined in base classes of cls.

@mrjoes mrjoes merged commit c5584e9 into mrjoes:master Mar 27, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment