New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newznab module #26

Closed
wants to merge 25 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@Jeroenve
Contributor

Jeroenve commented Dec 30, 2011

Searches are currently performed on the movies category only.

How can enter be disable in the form? At the moment /?query= gets loaded.

@Jeroenve Jeroenve referenced this pull request Dec 30, 2011

Closed

Newznab module added #20

@gugahoi

This comment has been minimized.

Collaborator

gugahoi commented Dec 30, 2011

I just coded something similar to this! Wish I had seen this before as it took me a while to understand the request object from flask. Will review this later on, if mrk doesn't beat me to it.

@gugahoi

This comment has been minimized.

Collaborator

gugahoi commented Dec 30, 2011

Can pull request #20 be closed?

@Jeroenve

This comment has been minimized.

Contributor

Jeroenve commented Dec 30, 2011

Yes, I closed it.

@Jeroenve

This comment has been minimized.

Contributor

Jeroenve commented Dec 31, 2011

Search boxSearch results

@N3MIS15

This comment has been minimized.

Collaborator

N3MIS15 commented Jan 1, 2012

nice work

@Jeroenve

This comment has been minimized.

Contributor

Jeroenve commented Jan 1, 2012

Thanks to spotweb, spotweb/details/xx page is now working!

To enable it, add to following line to .htaccess of spotweb apache configuration file:
RewriteRule ^details/?(.*)$ /spotweb/?page=getspot&messageid=$1 [L,QSA]

@mrkipling

This comment has been minimized.

Owner

mrkipling commented Jan 1, 2012

I like it! I don't use Newznab personally, but I tested it out using a public server and it seemed to work fine.

The interface needs some work though. Some things that I noticed:

  • Pressing enter in the search box reloads the page (something that should never be done in Maraschino as it's all AJAX)
  • The icons don't fit in with Maraschino's style, we're going for a simple, single colour (white) style
  • The styling needs work - the results are in a massive font size and the poster (is this useful information? what other information could be displayed?) is underneath and right-aligned

This definitely has potential. Would you be willing to make these changes?

@gugahoi

This comment has been minimized.

Collaborator

gugahoi commented Jan 2, 2012

I like this too but I was hoping to develop a search plugin sometime soon. It will most likely have nzb.su search functionality as well along with others. Will probably be something like the MFP one I once made, until then this is pretty cool.

@mrkipling

This comment has been minimized.

Owner

mrkipling commented Jan 2, 2012

I was also thinking when looking at this that an all-emcompassing search module would be the way forward, long-term, as there doesn't seem to be a definitive search tool that people use (I use binsearch.info, for example).

As gugahoi said, perhaps this module (after appropriate UI changes listed above) could fill the void until then, or evolve into something larger.

@Jeroenve

This comment has been minimized.

Contributor

Jeroenve commented Jan 2, 2012

I agree to you both, so one can extend this module or use this code into a new one that allows a user to select his search application.

Most icons are replaced by white one. Maybe some one can help me with fixing the enter issue.

@mrkipling

This comment has been minimized.

Owner

mrkipling commented Jan 2, 2012

Jeroenve, if you can take care of the rest then I can fix the enter issue when it comes to reviewing it.

@gugahoi

This comment has been minimized.

Collaborator

gugahoi commented Jan 2, 2012

Yes the enter issue is an easy one. There is code that does that already on index.js since I needed to do it with the Sickbeard Search as well (see here)

I thought we already had a ticket on lighthouse for a search module but can't find it anywhere. We can open this up for discussion and find ways to better implement it. Last time I spoke to @antant he mentioned he had started coding such a thing already but I have no idea what happened to it.

@Jeroenve

This comment has been minimized.

Contributor

Jeroenve commented Jan 2, 2012

Made most of the changes:
New version

@mrkipling

This comment has been minimized.

Owner

mrkipling commented Jan 2, 2012

Looks very nice, good job! Will check it out properly as soon as I get a chance.

@N3MIS15

This comment has been minimized.

Collaborator

N3MIS15 commented Jan 5, 2012

love this module.. It would be awsome if clicking the links could import nzb directly to sabnzbd ;)

@Jeroenve

This comment has been minimized.

Contributor

Jeroenve commented Jan 5, 2012

If there is an ability to check if the sabnzbd module is enabled then it should be possible to send a nzb to sabnzbd.

@gugahoi

This comment has been minimized.

Collaborator

gugahoi commented Jan 5, 2012

No need to check that. It definitely is possible to send to sab, even to choose the category, priority and everything.
If you happen to know any php, have a look at this. I coded that for MFP and it had a button where one clicked and the item was sent to SAB. You can also use this if you'd like to expand your module further as it has code to search both nzb.su, nzbmatrix and themoviedb (I know it's a messy coding, sorry)

@ghost

This comment has been minimized.

ghost commented Jan 5, 2012

No need to check if it's enabled. Just stick it in a try... except
On Jan 5, 2012 10:14 AM, "Jeroen van Emden" <
reply@reply.github.com>
wrote:

If there is an ability to check if the sabnzbd module is enabled then it
should be possible to send a nzb to sabnzbd.


Reply to this email directly or view it on GitHub:
#26 (comment)

@Jeroenve

This comment has been minimized.

Contributor

Jeroenve commented Jan 5, 2012

nzb.su is already possible as it uses newznab.

@Jeroenve

This comment has been minimized.

Contributor

Jeroenve commented Jan 7, 2012

Who has a NZB matrix apikey for me that I can use for the development?

@Nick-M

This comment has been minimized.

Nick-M commented Feb 6, 2012

any progress on this module?
would be nice if this one could be used in maraschino :-)

@mrkipling

This comment has been minimized.

Owner

mrkipling commented Feb 6, 2012

There's another pull request for a search feature, which still needs some work, but is (in my opinion) the right way to go vs. a Newznab-only module:

#63

@mrkipling mrkipling closed this Feb 6, 2012

@Nick-M

This comment has been minimized.

Nick-M commented Feb 6, 2012

k,thx for the info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment