New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement `PyObject#type` #2

Merged
merged 1 commit into from Feb 28, 2017

Conversation

Projects
None yet
2 participants
@yui-knk
Contributor

yui-knk commented Feb 27, 2017

This commit enables us to inspect a type of PyObject.
The class of PyObject instances are PyObject, so we have
no means to inspect types of these instances except checking
type of Python world.

@mrkn

This comment has been minimized.

Show comment
Hide comment
@mrkn

mrkn Feb 27, 2017

Owner

@yui-knk I was also adding attach_function PyObject_Type for implementing user-defined type conversion.
It conflicts your change in this pull-request.
Rebase the commit please.

Owner

mrkn commented Feb 27, 2017

@yui-knk I was also adding attach_function PyObject_Type for implementing user-defined type conversion.
It conflicts your change in this pull-request.
Rebase the commit please.

Implement `PyObject#type`
This commit enables us to inspect a type of `PyObject`.
The class of `PyObject` instances are `PyObject`, so we have
no means to inspect types of these instances except checking
type of Python world.
@yui-knk

This comment has been minimized.

Show comment
Hide comment
@yui-knk

yui-knk Feb 27, 2017

Contributor

Rebased!

Contributor

yui-knk commented Feb 27, 2017

Rebased!

@mrkn mrkn merged commit 009b2c6 into mrkn:master Feb 28, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@yui-knk yui-knk deleted the yui-knk:type branch Feb 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment