Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove symlinks for molecule tests #128

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

MoteHue
Copy link
Contributor

@MoteHue MoteHue commented May 22, 2024

Description

We are seeing failures with newer versions of Ansible due to the presence of symlinks. For example:

error: can't copy 'ansible/roles/mrlesmithjr.manage_lvm/molecule/kvm/tests': doesn't exist or not a regular file

Related Issue

#127

Types of changes

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • [ x] I have read the CONTRIBUTING document.
  • [ x] I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

We are seeing failures with newer versions of Ansible due to the
presence of symlinks. For example:

```
error: can't copy 'ansible/roles/mrlesmithjr.manage_lvm/molecule/kvm/tests': doesn't exist or not a regular file
```
@markgoddard
Copy link

@mrlesmithjr could you take a look at this one please?

@mrlesmithjr
Copy link
Owner

@markgoddard - These look okay to me at first glance.

@mnasiadka
Copy link
Contributor

@mrlesmithjr Any chance to get that merged and released?

@mrlesmithjr mrlesmithjr merged commit 26246c7 into mrlesmithjr:master Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants