Navigation Menu

Skip to content

Commit

Permalink
Merge pull request #159 from naoa/support-generted-stored-column
Browse files Browse the repository at this point in the history
Support generated column

Patch by Naoya Murakami. Thanks!!!
  • Loading branch information
kou committed Aug 13, 2017
2 parents 6a04a9d + 56a1c27 commit 18be2e8
Show file tree
Hide file tree
Showing 17 changed files with 460 additions and 0 deletions.
6 changes: 6 additions & 0 deletions ha_mroonga.cpp
Expand Up @@ -2807,6 +2807,9 @@ ulonglong ha_mroonga::wrapper_table_flags() const
#endif
#ifdef HA_CAN_FULLTEXT_EXT
table_flags |= HA_CAN_FULLTEXT_EXT;
#endif
#ifdef HA_GENERATED_COLUMNS
table_flags |= HA_GENERATED_COLUMNS;
#endif
DBUG_RETURN(table_flags);
}
Expand Down Expand Up @@ -2836,6 +2839,9 @@ ulonglong ha_mroonga::storage_table_flags() const
#endif
#ifdef HA_CAN_FULLTEXT_EXT
flags |= HA_CAN_FULLTEXT_EXT;
#endif
#ifdef HA_GENERATED_COLUMNS
flags |= HA_GENERATED_COLUMNS;
#endif
DBUG_RETURN(flags);
}
Expand Down
15 changes: 15 additions & 0 deletions mysql-test/mroonga/storage/column/generated/stored/r/delete.result
@@ -0,0 +1,15 @@
DROP TABLE IF EXISTS logs;
CREATE TABLE logs (
id INT,
record JSON,
message VARCHAR(255) GENERATED ALWAYS AS (json_extract(`record`, '$.message')) STORED,
FULLTEXT INDEX(message) comment 'tokenizer "TokenBigramSplitSymbolAlphaDigit"'
) ENGINE=Mroonga DEFAULT CHARSET=utf8mb4;
INSERT INTO logs(id, record) VALUES (1, '{"level": "info", "message": "start"}');
INSERT INTO logs(id, record) VALUES (2, '{"level": "info", "message": "restart"}');
INSERT INTO logs(id, record) VALUES (3, '{"level": "warn", "message": "abort"}');
DELETE FROM logs WHERE id = 1;
SELECT * FROM logs WHERE MATCH(message) AGAINST("ar" IN BOOLEAN MODE);
id record message
2 {"level": "info", "message": "restart"} "restart"
DROP TABLE logs;
15 changes: 15 additions & 0 deletions mysql-test/mroonga/storage/column/generated/stored/r/insert.result
@@ -0,0 +1,15 @@
DROP TABLE IF EXISTS logs;
CREATE TABLE logs (
id INT,
record JSON,
message VARCHAR(255) GENERATED ALWAYS AS (json_extract(`record`, '$.message')) STORED,
FULLTEXT INDEX(message) comment 'tokenizer "TokenBigramSplitSymbolAlphaDigit"'
) ENGINE=Mroonga DEFAULT CHARSET=utf8mb4;
INSERT INTO logs(id, record) VALUES (1, '{"level": "info", "message": "start"}');
INSERT INTO logs(id, record) VALUES (2, '{"level": "info", "message": "restart"}');
INSERT INTO logs(id, record) VALUES (3, '{"level": "warn", "message": "abort"}');
SELECT * FROM logs WHERE MATCH(message) AGAINST("ar" IN BOOLEAN MODE);
id record message
1 {"level": "info", "message": "start"} "start"
2 {"level": "info", "message": "restart"} "restart"
DROP TABLE logs;
@@ -0,0 +1,17 @@
DROP TABLE IF EXISTS logs;
CREATE TABLE logs (
id INT,
record JSON,
message VARCHAR(255) GENERATED ALWAYS AS (json_extract(`record`, '$.message')) STORED,
FULLTEXT INDEX(message) comment 'tokenizer "TokenBigramSplitSymbolAlphaDigit"'
) ENGINE=Mroonga DEFAULT CHARSET=utf8mb4;
INSERT INTO logs(id, record) VALUES (1, '{"level": "info", "message": "start"}');
INSERT INTO logs(id, record) VALUES (2, '{"level": "info", "message": "restart"}');
INSERT INTO logs(id, record) VALUES (3, '{"level": "warn", "message": "abort"}');
ALTER TABLE logs disable keys;
ALTER TABLE logs enable keys;
SELECT * FROM logs WHERE MATCH(message) AGAINST("ar" IN BOOLEAN MODE);
id record message
1 {"level": "info", "message": "start"} "start"
2 {"level": "info", "message": "restart"} "restart"
DROP TABLE logs;
15 changes: 15 additions & 0 deletions mysql-test/mroonga/storage/column/generated/stored/r/update.result
@@ -0,0 +1,15 @@
DROP TABLE IF EXISTS logs;
CREATE TABLE logs (
id INT,
record JSON,
message VARCHAR(255) GENERATED ALWAYS AS (json_extract(`record`, '$.message')) STORED,
FULLTEXT INDEX(message) comment 'tokenizer "TokenBigramSplitSymbolAlphaDigit"'
) ENGINE=Mroonga DEFAULT CHARSET=utf8mb4;
INSERT INTO logs(id, record) VALUES (1, '{"level": "info", "message": "start"}');
INSERT INTO logs(id, record) VALUES (2, '{"level": "info", "message": "restart"}');
INSERT INTO logs(id, record) VALUES (3, '{"level": "warn", "message": "abort"}');
UPDATE logs SET record = '{"level": "info", "message": "shutdown"}' WHERE id = 2;
SELECT * FROM logs WHERE MATCH(message) AGAINST("hut" IN BOOLEAN MODE);
id record message
2 {"level": "info", "message": "shutdown"} "shutdown"
DROP TABLE logs;
41 changes: 41 additions & 0 deletions mysql-test/mroonga/storage/column/generated/stored/t/delete.test
@@ -0,0 +1,41 @@
# Copyright(C) 2017 Naoya Murakami <naoya@createfield.com>
#
# This library is free software; you can redistribute it and/or
# modify it under the terms of the GNU Lesser General Public
# License as published by the Free Software Foundation; either
# version 2.1 of the License, or (at your option) any later version.
#
# This library is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
# Lesser General Public License for more details.
#
# You should have received a copy of the GNU Lesser General Public
# License along with this library; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA

--source ../../../../../include/mroonga/have_mysql_5_7_or_later.inc
--source ../../../../../include/mroonga/have_mroonga.inc

--disable_warnings
DROP TABLE IF EXISTS logs;
--enable_warnings

CREATE TABLE logs (
id INT,
record JSON,
message VARCHAR(255) GENERATED ALWAYS AS (json_extract(`record`, '$.message')) STORED,
FULLTEXT INDEX(message) comment 'tokenizer "TokenBigramSplitSymbolAlphaDigit"'
) ENGINE=Mroonga DEFAULT CHARSET=utf8mb4;

INSERT INTO logs(id, record) VALUES (1, '{"level": "info", "message": "start"}');
INSERT INTO logs(id, record) VALUES (2, '{"level": "info", "message": "restart"}');
INSERT INTO logs(id, record) VALUES (3, '{"level": "warn", "message": "abort"}');

DELETE FROM logs WHERE id = 1;

SELECT * FROM logs WHERE MATCH(message) AGAINST("ar" IN BOOLEAN MODE);

DROP TABLE logs;

--source ../../../../../include/mroonga/have_mroonga_deinit.inc
39 changes: 39 additions & 0 deletions mysql-test/mroonga/storage/column/generated/stored/t/insert.test
@@ -0,0 +1,39 @@
# Copyright(C) 2017 Naoya Murakami <naoya@createfield.com>
#
# This library is free software; you can redistribute it and/or
# modify it under the terms of the GNU Lesser General Public
# License as published by the Free Software Foundation; either
# version 2.1 of the License, or (at your option) any later version.
#
# This library is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
# Lesser General Public License for more details.
#
# You should have received a copy of the GNU Lesser General Public
# License along with this library; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA

--source ../../../../../include/mroonga/have_mysql_5_7_or_later.inc
--source ../../../../../include/mroonga/have_mroonga.inc

--disable_warnings
DROP TABLE IF EXISTS logs;
--enable_warnings

CREATE TABLE logs (
id INT,
record JSON,
message VARCHAR(255) GENERATED ALWAYS AS (json_extract(`record`, '$.message')) STORED,
FULLTEXT INDEX(message) comment 'tokenizer "TokenBigramSplitSymbolAlphaDigit"'
) ENGINE=Mroonga DEFAULT CHARSET=utf8mb4;

INSERT INTO logs(id, record) VALUES (1, '{"level": "info", "message": "start"}');
INSERT INTO logs(id, record) VALUES (2, '{"level": "info", "message": "restart"}');
INSERT INTO logs(id, record) VALUES (3, '{"level": "warn", "message": "abort"}');

SELECT * FROM logs WHERE MATCH(message) AGAINST("ar" IN BOOLEAN MODE);

DROP TABLE logs;

--source ../../../../../include/mroonga/have_mroonga_deinit.inc
42 changes: 42 additions & 0 deletions mysql-test/mroonga/storage/column/generated/stored/t/reindex.test
@@ -0,0 +1,42 @@
# Copyright(C) 2017 Naoya Murakami <naoya@createfield.com>
#
# This library is free software; you can redistribute it and/or
# modify it under the terms of the GNU Lesser General Public
# License as published by the Free Software Foundation; either
# version 2.1 of the License, or (at your option) any later version.
#
# This library is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
# Lesser General Public License for more details.
#
# You should have received a copy of the GNU Lesser General Public
# License along with this library; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA

--source ../../../../../include/mroonga/have_mysql_5_7_or_later.inc
--source ../../../../../include/mroonga/have_mroonga.inc

--disable_warnings
DROP TABLE IF EXISTS logs;
--enable_warnings

CREATE TABLE logs (
id INT,
record JSON,
message VARCHAR(255) GENERATED ALWAYS AS (json_extract(`record`, '$.message')) STORED,
FULLTEXT INDEX(message) comment 'tokenizer "TokenBigramSplitSymbolAlphaDigit"'
) ENGINE=Mroonga DEFAULT CHARSET=utf8mb4;

INSERT INTO logs(id, record) VALUES (1, '{"level": "info", "message": "start"}');
INSERT INTO logs(id, record) VALUES (2, '{"level": "info", "message": "restart"}');
INSERT INTO logs(id, record) VALUES (3, '{"level": "warn", "message": "abort"}');

ALTER TABLE logs disable keys;
ALTER TABLE logs enable keys;

SELECT * FROM logs WHERE MATCH(message) AGAINST("ar" IN BOOLEAN MODE);

DROP TABLE logs;

--source ../../../../../include/mroonga/have_mroonga_deinit.inc
41 changes: 41 additions & 0 deletions mysql-test/mroonga/storage/column/generated/stored/t/update.test
@@ -0,0 +1,41 @@
# Copyright(C) 2017 Naoya Murakami <naoya@createfield.com>
#
# This library is free software; you can redistribute it and/or
# modify it under the terms of the GNU Lesser General Public
# License as published by the Free Software Foundation; either
# version 2.1 of the License, or (at your option) any later version.
#
# This library is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
# Lesser General Public License for more details.
#
# You should have received a copy of the GNU Lesser General Public
# License along with this library; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA

--source ../../../../../include/mroonga/have_mysql_5_7_or_later.inc
--source ../../../../../include/mroonga/have_mroonga.inc

--disable_warnings
DROP TABLE IF EXISTS logs;
--enable_warnings

CREATE TABLE logs (
id INT,
record JSON,
message VARCHAR(255) GENERATED ALWAYS AS (json_extract(`record`, '$.message')) STORED,
FULLTEXT INDEX(message) comment 'tokenizer "TokenBigramSplitSymbolAlphaDigit"'
) ENGINE=Mroonga DEFAULT CHARSET=utf8mb4;

INSERT INTO logs(id, record) VALUES (1, '{"level": "info", "message": "start"}');
INSERT INTO logs(id, record) VALUES (2, '{"level": "info", "message": "restart"}');
INSERT INTO logs(id, record) VALUES (3, '{"level": "warn", "message": "abort"}');

UPDATE logs SET record = '{"level": "info", "message": "shutdown"}' WHERE id = 2;

SELECT * FROM logs WHERE MATCH(message) AGAINST("hut" IN BOOLEAN MODE);

DROP TABLE logs;

--source ../../../../../include/mroonga/have_mroonga_deinit.inc
15 changes: 15 additions & 0 deletions mysql-test/mroonga/wrapper/column/generated/stored/r/delete.result
@@ -0,0 +1,15 @@
DROP TABLE IF EXISTS logs;
CREATE TABLE logs (
id INT PRIMARY KEY,
record JSON,
message VARCHAR(255) GENERATED ALWAYS AS (json_extract(`record`, '$.message')) STORED,
FULLTEXT INDEX(message) comment 'tokenizer "TokenBigramSplitSymbolAlphaDigit"'
) ENGINE=Mroonga DEFAULT CHARSET=utf8mb4 COMMENT = 'ENGINE "InnoDB"';
INSERT INTO logs(id, record) VALUES (1, '{"level": "info", "message": "start"}');
INSERT INTO logs(id, record) VALUES (2, '{"level": "info", "message": "restart"}');
INSERT INTO logs(id, record) VALUES (3, '{"level": "warn", "message": "abort"}');
DELETE FROM logs WHERE id = 1;
SELECT * FROM logs WHERE MATCH(message) AGAINST("ar" IN BOOLEAN MODE);
id record message
2 {"level": "info", "message": "restart"} "restart"
DROP TABLE logs;
15 changes: 15 additions & 0 deletions mysql-test/mroonga/wrapper/column/generated/stored/r/insert.result
@@ -0,0 +1,15 @@
DROP TABLE IF EXISTS logs;
CREATE TABLE logs (
id INT PRIMARY KEY,
record JSON,
message VARCHAR(255) GENERATED ALWAYS AS (json_extract(`record`, '$.message')) STORED,
FULLTEXT INDEX(message) comment 'tokenizer "TokenBigramSplitSymbolAlphaDigit"'
) ENGINE=Mroonga DEFAULT CHARSET=utf8mb4 COMMENT = 'ENGINE "InnoDB"';
INSERT INTO logs(id, record) VALUES (1, '{"level": "info", "message": "start"}');
INSERT INTO logs(id, record) VALUES (2, '{"level": "info", "message": "restart"}');
INSERT INTO logs(id, record) VALUES (3, '{"level": "warn", "message": "abort"}');
SELECT * FROM logs WHERE MATCH(message) AGAINST("ar" IN BOOLEAN MODE);
id record message
1 {"level": "info", "message": "start"} "start"
2 {"level": "info", "message": "restart"} "restart"
DROP TABLE logs;
@@ -0,0 +1,17 @@
DROP TABLE IF EXISTS logs;
CREATE TABLE logs (
id INT PRIMARY KEY,
record JSON,
message VARCHAR(255) GENERATED ALWAYS AS (json_extract(`record`, '$.message')) STORED,
FULLTEXT INDEX(message) comment 'tokenizer "TokenBigramSplitSymbolAlphaDigit"'
) ENGINE=Mroonga DEFAULT CHARSET=utf8mb4 COMMENT = 'ENGINE "InnoDB"';
INSERT INTO logs(id, record) VALUES (1, '{"level": "info", "message": "start"}');
INSERT INTO logs(id, record) VALUES (2, '{"level": "info", "message": "restart"}');
INSERT INTO logs(id, record) VALUES (3, '{"level": "warn", "message": "abort"}');
ALTER TABLE logs disable keys;
ALTER TABLE logs enable keys;
SELECT * FROM logs WHERE MATCH(message) AGAINST("ar" IN BOOLEAN MODE);
id record message
1 {"level": "info", "message": "start"} "start"
2 {"level": "info", "message": "restart"} "restart"
DROP TABLE logs;
15 changes: 15 additions & 0 deletions mysql-test/mroonga/wrapper/column/generated/stored/r/update.result
@@ -0,0 +1,15 @@
DROP TABLE IF EXISTS logs;
CREATE TABLE logs (
id INT PRIMARY KEY,
record JSON,
message VARCHAR(255) GENERATED ALWAYS AS (json_extract(`record`, '$.message')) STORED,
FULLTEXT INDEX(message) comment 'tokenizer "TokenBigramSplitSymbolAlphaDigit"'
) ENGINE=Mroonga DEFAULT CHARSET=utf8mb4 COMMENT = 'ENGINE "InnoDB"';
INSERT INTO logs(id, record) VALUES (1, '{"level": "info", "message": "start"}');
INSERT INTO logs(id, record) VALUES (2, '{"level": "info", "message": "restart"}');
INSERT INTO logs(id, record) VALUES (3, '{"level": "warn", "message": "abort"}');
UPDATE logs SET record = '{"level": "info", "message": "shutdown"}' WHERE id = 2;
SELECT * FROM logs WHERE MATCH(message) AGAINST("hut" IN BOOLEAN MODE);
id record message
2 {"level": "info", "message": "shutdown"} "shutdown"
DROP TABLE logs;
42 changes: 42 additions & 0 deletions mysql-test/mroonga/wrapper/column/generated/stored/t/delete.test
@@ -0,0 +1,42 @@
# Copyright(C) 2017 Naoya Murakami <naoya@createfield.com>
#
# This library is free software; you can redistribute it and/or
# modify it under the terms of the GNU Lesser General Public
# License as published by the Free Software Foundation; either
# version 2.1 of the License, or (at your option) any later version.
#
# This library is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
# Lesser General Public License for more details.
#
# You should have received a copy of the GNU Lesser General Public
# License along with this library; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA

--source include/have_innodb.inc
--source ../../../../../include/mroonga/have_mysql_5_7_or_later.inc
--source ../../../../../include/mroonga/have_mroonga.inc

--disable_warnings
DROP TABLE IF EXISTS logs;
--enable_warnings

CREATE TABLE logs (
id INT PRIMARY KEY,
record JSON,
message VARCHAR(255) GENERATED ALWAYS AS (json_extract(`record`, '$.message')) STORED,
FULLTEXT INDEX(message) comment 'tokenizer "TokenBigramSplitSymbolAlphaDigit"'
) ENGINE=Mroonga DEFAULT CHARSET=utf8mb4 COMMENT = 'ENGINE "InnoDB"';

INSERT INTO logs(id, record) VALUES (1, '{"level": "info", "message": "start"}');
INSERT INTO logs(id, record) VALUES (2, '{"level": "info", "message": "restart"}');
INSERT INTO logs(id, record) VALUES (3, '{"level": "warn", "message": "abort"}');

DELETE FROM logs WHERE id = 1;

SELECT * FROM logs WHERE MATCH(message) AGAINST("ar" IN BOOLEAN MODE);

DROP TABLE logs;

--source ../../../../../include/mroonga/have_mroonga_deinit.inc

0 comments on commit 18be2e8

Please sign in to comment.