Extract assignment expression from if condition

mroonga · Feb 4, 2014 · 512e73e · 512e73e
1 parent fbfd93c
commit 512e73e
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/ha_mroonga.cpp b/ha_mroonga.cpp
@@ -1183,7 +1183,8 @@ static int mrn_set_geometry(grn_ctx *ctx, grn_obj *buf,
   Geometry_buffer buffer;
   Geometry *geometry;
 
-  if (!(geometry = Geometry::construct(&buffer, wkb, wkb_size))) {
+  geometry = Geometry::construct(&buffer, wkb, wkb_size);
+  if (!geometry) {
     return -1;
   }
   switch (geometry->get_class_info()->m_type_id) {