Navigation Menu

Skip to content

Commit

Permalink
Fix a memory leak
Browse files Browse the repository at this point in the history
Column caches aren't freed.
  • Loading branch information
kou committed Apr 25, 2018
1 parent c34874e commit ca20ae4
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions ha_mroonga.cpp
Expand Up @@ -5076,6 +5076,8 @@ void ha_mroonga::storage_close_columns(void)

free(grn_columns);
grn_columns = NULL;
free(grn_column_caches);
grn_column_caches = NULL;
free(grn_column_ranges);
grn_column_ranges = NULL;
}
Expand Down Expand Up @@ -5266,11 +5268,8 @@ int ha_mroonga::wrapper_close()
int ha_mroonga::storage_close()
{
MRN_DBUG_ENTER_METHOD();
storage_close_columns();
grn_obj_unlink(ctx, grn_table);
// TODO: unlink elements
free(grn_columns);
// TODO: unlink elements
free(grn_column_ranges);
DBUG_RETURN(0);
}

Expand Down

0 comments on commit ca20ae4

Please sign in to comment.