Navigation Menu

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mroonga/mroonga
base: 2241a88711e0
Choose a base ref
...
head repository: mroonga/mroonga
compare: c4b16ed9d95a
Choose a head ref
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Nov 17, 2013

  1. Move version check to hpp from cpp 

    We should check MySQL version and define logical flags in hpp and use
them in cpp. It improves maintenability.

Some flags are used in two or more locations. If they are used in two
or more locations, we need to write the same version check conditions
there. It reduces maintenability:

Not good:

    #if MYSQL_VERSION_ID >= 50607
      // code1
    #endif
      // ...
    #if MYSQL_VERSION_ID >= 50607
      // code2
    #endif

Better:

    #if MYSQL_VERSION_ID >= 50607
    #  define LOGICAL_FLAG
    #endif

    #ifdef LOGICAL_FLAG
      // code1
    #endif
      // ...
    #ifdef LOGICAL_FLAG
      // code2
    #endif
    @kou
    kou committed Nov 17, 2013
    Copy the full SHA
    c4b16ed View commit details
    Browse the repository at this point in the history